Re: [PATCH v10.1 5/7] bisect: simplify the addition of new bisect terms

From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com,
	Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>,
	Louis Stuber <stuberl@ensimag.grenoble-inp.fr>,
	Valentin Duperray <Valentin.Duperray@ensimag.imag.fr>,
	Franck Jonas <Franck.Jonas@ensimag.imag.fr>,
	Lucien Kong <Lucien.Kong@ensimag.imag.fr>,
	Thomas Nguy <Thomas.Nguy@ensimag.imag.fr>,
	Huynh Khoi Nguyen Nguyen 
	<Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>
Subject: Re: [PATCH v10.1 5/7] bisect: simplify the addition of new bisect terms
Date: Fri, 26 Jun 2015 23:37:40 +0200	[thread overview]
Message-ID: <vpqioaap2vv.fsf@anie.imag.fr> (raw)
In-Reply-To: <xmqq381etb1e.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Fri, 26 Jun 2015 14:27:57 -0700")

Junio C Hamano <gitster@pobox.com> writes:

>>  static int for_each_bad_bisect_ref(const char *submodule, each_ref_fn fn, void *cb_data)
>>  {
>> -	return for_each_ref_in_submodule(submodule, "refs/bisect/bad", fn, cb_data);
>> +	return for_each_bisect_ref(submodule, fn, cb_data, "bad");
>>  }
>
> Shouldn't this be passing name_bad instead of "bad"?
>
>>  
>>  static int for_each_good_bisect_ref(const char *submodule, each_ref_fn fn, void *cb_data)
>>  {
>> -	return for_each_ref_in_submodule(submodule, "refs/bisect/good", fn, cb_data);
>> +	return for_each_bisect_ref(submodule, fn, cb_data, "good");
>>  }
>
> Likewise.

Indeed. Fixed.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/