From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: "David Aguilar" <davvid@gmail.com>,
git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"René Scharfe" <l.s.r@web.de>
Subject: Re: [RFC PATCH v2 1/2] Makefile: add check-headers target
Date: Wed, 10 Sep 2014 19:24:50 +0200 [thread overview]
Message-ID: <vpqk35bo0bh.fsf@anie.imag.fr> (raw)
In-Reply-To: <xmqq38bzieqj.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Wed, 10 Sep 2014 10:09:56 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> David Aguilar <davvid@gmail.com> writes:
>
>> On Mon, Sep 08, 2014 at 12:57:46PM -0700, Junio C Hamano wrote:
>>> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>>> ...
>>> > for header in .h ewah/*.h vcs-svn/*.h xdiff/*.h
>>> > do
>>> > ...
>>> > done
>>>
>>> Yes, that would be even better. Then you wouldn't even have to
>>> worry about $IFS dance.
>>
>> The original motivation was to avoid picking up the generated
>> common-cmds.h header file.
>
> for header
> do
> case "$header" in $exceptions) continue ;; esac
> ...
> done
>
> with comments describing why these exceptions are made would be a
> better way to go in such a case.
+1 from me. It would allow developers to use the rule without "git
add"-ing new .h files, and the comment would document why the
exceptions are there (which missed in the original patch IMHO).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
prev parent reply other threads:[~2014-09-10 17:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 0:30 [RFC PATCH v2 1/2] Makefile: add check-headers target David Aguilar
2014-09-07 0:30 ` [RFC PATCH v2 2/2] headers: include dependent headers David Aguilar
2014-09-07 6:41 ` René Scharfe
2014-09-07 19:49 ` Jonathan Nieder
2014-09-07 19:54 ` Johannes Sixt
2014-09-07 20:01 ` Jonathan Nieder
2014-09-07 20:30 ` David Aguilar
2014-09-07 19:42 ` [RFC PATCH v2 1/2] Makefile: add check-headers target Jonathan Nieder
2014-09-08 18:56 ` Junio C Hamano
2014-09-08 19:29 ` Matthieu Moy
2014-09-08 19:57 ` Junio C Hamano
2014-09-10 0:03 ` David Aguilar
2014-09-10 17:09 ` Junio C Hamano
2014-09-10 17:24 ` Matthieu Moy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqk35bo0bh.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.