All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com
Subject: Re: [PATCH v3 01/11] t6301: for-each-ref tests for ref-filter APIs
Date: Tue, 16 Jun 2015 17:21:51 +0200	[thread overview]
Message-ID: <vpqmvzz8yr4.fsf@anie.imag.fr> (raw)
In-Reply-To: <1434464457-10749-1-git-send-email-karthik.188@gmail.com> (Karthik Nayak's message of "Tue, 16 Jun 2015 19:50:47 +0530")

Karthik Nayak <karthik.188@gmail.com> writes:

> Add tests for 'for-each-ref' which utilizes the ref-filter APIs.
> Currently it's redundant with the tests in 't6300' but more tests
> will be eventually added as we implement more options into
> 'for-each-ref'.

Actually, I'm not convinced that the actual tests have a real value
(since as you say, it's redundant with t6300). Perhaps we can limit this
commit to the setup.

> +++ b/t/t6301-for-each-ref-filter.sh
> @@ -0,0 +1,36 @@
> +#!/bin/sh
> +
> +test_description='test for-each-refs usage of ref-filter APIs'
> +
> +. ./test-lib.sh
> +. "$TEST_DIRECTORY"/lib-gpg.sh

You are not using lib-gpg.sh, right?

If first thought it was an incorrect cut-and-paste, but I actually think
that you need to setup a signed tag to properly test the --points-at
option (it does not only list refs pointing directly at a commit, but
also refs pointing at a tag pointing at the given commit).

Such signed tag could be added here and used later in PATCH 04.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  parent reply	other threads:[~2015-06-16 15:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16 14:19 [PATCH v3 00/11] add options to for-each-ref karthik nayak
2015-06-16 14:20 ` [PATCH v3 01/11] t6301: for-each-ref tests for ref-filter APIs Karthik Nayak
2015-06-16 14:20   ` [PATCH v3 02/11] tag: libify parse_opt_points_at() Karthik Nayak
2015-06-16 14:20   ` [PATCH v3 03/11] ref-filter: implement '--points-at' option Karthik Nayak
2015-06-16 14:20   ` [PATCH v3 04/11] for-each-ref: add " Karthik Nayak
2015-06-16 16:00     ` Matthieu Moy
2015-06-16 16:02       ` karthik nayak
2015-06-16 14:20   ` [PATCH v3 05/11] ref-filter: add parse_opt_merge_filter() Karthik Nayak
2015-06-16 16:18     ` Matthieu Moy
2015-06-16 16:30       ` karthik nayak
2015-06-17  8:27         ` Matthieu Moy
2015-06-17 19:12           ` karthik nayak
2015-06-16 14:20   ` [PATCH v3 06/11] ref-filter: implement '--merged' and '--no-merged' options Karthik Nayak
2015-06-17  8:38     ` Matthieu Moy
2015-06-17 19:49       ` karthik nayak
2015-06-16 14:20   ` [PATCH v3 07/11] for-each-ref: add " Karthik Nayak
2015-06-16 14:20   ` [PATCH v3 08/11] parse-option: rename parse_opt_with_commit() Karthik Nayak
2015-06-16 14:20   ` [PATCH v3 09/11] parse-options.h: add macros for '--contains' option Karthik Nayak
2015-06-16 14:20   ` [PATCH v3 10/11] ref-filter: implement " Karthik Nayak
2015-06-16 14:20   ` [PATCH v3 11/11] for-each-ref: add " Karthik Nayak
2015-06-17  8:40     ` Matthieu Moy
2015-06-16 15:21   ` Matthieu Moy [this message]
2015-06-16 16:01     ` [PATCH v3 01/11] t6301: for-each-ref tests for ref-filter APIs karthik nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqmvzz8yr4.fsf@anie.imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.