From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: davi.reis@gmail.com
Cc: git@vger.kernel.org
Subject: Re: Do not let lstree output recursively when a directory whose name is a prefix of the others is given in the path list.
Date: Thu, 09 Sep 2010 08:04:16 +0200 [thread overview]
Message-ID: <vpqzkvr5u73.fsf@bauges.imag.fr> (raw)
In-Reply-To: <1284010826-81989-1-git-send-email-davi.reis@gmail.com> (davi reis's message of "Wed\, 8 Sep 2010 22\:40\:25 -0700")
davi.reis@gmail.com writes:
> Here is how to reproduce the bug:
>
> git init
> mkdir prefix && touch prefix/a && git add prefix/a
> mkdir prefixdir && touch prefixdir/b && git add prefixdir/b
> git commit -a -m "If -r is not given, ls-tree should not show files in subdirs."
> git ls-tree --name-only HEAD prefix # works as expected
> git ls-tree --name-only HEAD prefixdir # works as expected
> git ls-tree --name-only HEAD prefix prefixdir # shows file, not dir
That's so close to a real test-case... You should incorporate this in
your patch (e.g. in t/t3101-ls-tree-dirname.sh), to make sure such bug
never happens again.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2010-09-09 6:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 5:40 Do not let lstree output recursively when a directory whose name is a prefix of the others is given in the path list davi.reis
2010-09-09 5:40 ` [PATCH] " davi.reis
2010-09-09 6:04 ` Matthieu Moy [this message]
2010-09-09 18:26 ` Davi Reis
2010-09-09 21:22 ` Matthieu Moy
2010-09-11 18:57 ` Junio C Hamano
2010-09-11 19:00 ` [PATCH 2/2] ls-tree $di $dir: do not mistakenly recurse into directories Junio C Hamano
2010-09-14 21:22 ` Do not let lstree output recursively when a directory whose name is a prefix of the others is given in the path list Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqzkvr5u73.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=davi.reis@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.