From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF5D6C433DB for ; Wed, 10 Feb 2021 13:39:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EF6364E79 for ; Wed, 10 Feb 2021 13:39:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EF6364E79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=emersion.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B8FA36E081; Wed, 10 Feb 2021 13:39:02 +0000 (UTC) Received: from mail-40133.protonmail.ch (mail-40133.protonmail.ch [185.70.40.133]) by gabe.freedesktop.org (Postfix) with ESMTPS id 55C9B6E081 for ; Wed, 10 Feb 2021 13:39:01 +0000 (UTC) Date: Wed, 10 Feb 2021 13:38:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail3; t=1612964338; bh=KXrzTlP6PgiuyJmaWvQDi11Oh2GB1xK04B3bvmGLmWY=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=jj+6ttuViw3KYXNZ4zf4iwVrmc2yvDFL/g9ytF8q9ntElJJYPPWA0MaPGpTx9DBfa u1PqbndshcE4SgPw/LKpmMau+xMRPZ9Upw29cUDcmKQ1oUa65AEBpcXS6p7EgUSfFn NsWnk4wQLjC3C5w8/57dKh7s/0P3TFokvWmxcfE3zCZ/K+auT3neWHUJanrrHJaxrL nqdj6fGI6gikfMXDOvauqhShs1aBm2NVdmWpUR1//pLGHk+99Rc9J9d3J3xy5kQ93A qVMoXanCxwh0u90iVB8bibV5xFPGV5k3gtP4q+nKWB1UWOBj3bDk0MVzr5ybnr3mKI qApyhwKM7/0nA== To: Daniel Vetter From: Simon Ser Subject: Re: [Intel-gfx] [PATCH] Revert "drm/atomic: document and enforce rules around "spurious" EBUSY" Message-ID: In-Reply-To: References: <20210210001401.463-1-manasi.d.navare@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Simon Ser Cc: Manasi Navare , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wednesday, February 10th, 2021 at 2:16 PM, Daniel Vetter wrote: > On Tue, Feb 09, 2021 at 04:14:01PM -0800, Manasi Navare wrote: > > > These additional checks added to avoid EBUSY give unnecessary WARN_ON > > in case of big joiner used in i915 in which case even if the modeset > > is requested on a single pipe, internally another consecutive > > pipe is stolen and used to drive half of the transcoder timings. > > So in this case it is expected that requested crtc and affected crtcs > > do not match. Hence the added WARN ON becomes irrelevant. The WARN_ON only happens if allow_modeset == false. If allow_modeset == true, then the driver is allowed to steal an unrelated pipe. Maybe i915 is stealing a pipe without allow_modeset? > Nope. We can maybe rework this so that i915 can do stuff under the hood, > but wrt uapi this was the thing we discussed with compositors. Without > such a guarantee atomic is defacto broken from a compositor pov. Agreed. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D7BBC433E0 for ; Wed, 10 Feb 2021 13:39:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C991E64E77 for ; Wed, 10 Feb 2021 13:39:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C991E64E77 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=emersion.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3FA9D6E079; Wed, 10 Feb 2021 13:39:07 +0000 (UTC) Received: from mail-41103.protonmail.ch (mail-41103.protonmail.ch [185.70.41.103]) by gabe.freedesktop.org (Postfix) with ESMTPS id D59B36E2C0 for ; Wed, 10 Feb 2021 13:39:05 +0000 (UTC) Received: from mail-02.mail-europe.com (mail-02.mail-europe.com [51.89.119.103]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail-41103.protonmail.ch (Postfix) with ESMTPS id 04C00200043B for ; Wed, 10 Feb 2021 13:39:04 +0000 (UTC) Authentication-Results: mail-41103.protonmail.ch; dkim=pass (2048-bit key) header.d=emersion.fr header.i=@emersion.fr header.b="jj+6ttuV" Date: Wed, 10 Feb 2021 13:38:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail3; t=1612964338; bh=KXrzTlP6PgiuyJmaWvQDi11Oh2GB1xK04B3bvmGLmWY=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=jj+6ttuViw3KYXNZ4zf4iwVrmc2yvDFL/g9ytF8q9ntElJJYPPWA0MaPGpTx9DBfa u1PqbndshcE4SgPw/LKpmMau+xMRPZ9Upw29cUDcmKQ1oUa65AEBpcXS6p7EgUSfFn NsWnk4wQLjC3C5w8/57dKh7s/0P3TFokvWmxcfE3zCZ/K+auT3neWHUJanrrHJaxrL nqdj6fGI6gikfMXDOvauqhShs1aBm2NVdmWpUR1//pLGHk+99Rc9J9d3J3xy5kQ93A qVMoXanCxwh0u90iVB8bibV5xFPGV5k3gtP4q+nKWB1UWOBj3bDk0MVzr5ybnr3mKI qApyhwKM7/0nA== To: Daniel Vetter From: Simon Ser Message-ID: In-Reply-To: References: <20210210001401.463-1-manasi.d.navare@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] Revert "drm/atomic: document and enforce rules around "spurious" EBUSY" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Simon Ser Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wednesday, February 10th, 2021 at 2:16 PM, Daniel Vetter wrote: > On Tue, Feb 09, 2021 at 04:14:01PM -0800, Manasi Navare wrote: > > > These additional checks added to avoid EBUSY give unnecessary WARN_ON > > in case of big joiner used in i915 in which case even if the modeset > > is requested on a single pipe, internally another consecutive > > pipe is stolen and used to drive half of the transcoder timings. > > So in this case it is expected that requested crtc and affected crtcs > > do not match. Hence the added WARN ON becomes irrelevant. The WARN_ON only happens if allow_modeset == false. If allow_modeset == true, then the driver is allowed to steal an unrelated pipe. Maybe i915 is stealing a pipe without allow_modeset? > Nope. We can maybe rework this so that i915 can do stuff under the hood, > but wrt uapi this was the thing we discussed with compositors. Without > such a guarantee atomic is defacto broken from a compositor pov. Agreed. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx