All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier.adi@gmail.com>
To: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
Cc: linux-usb@vger.kernel.org, Greg KH <greg@kroah.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] USB: gadget: __init and __exit tags removed
Date: Mon, 19 Apr 2010 04:02:48 -0400	[thread overview]
Message-ID: <w2v8bd0f97a1004190102pd928e442td837c8fcee0541c5@mail.gmail.com> (raw)
In-Reply-To: <op.vbegell27p4s8u@pikus>

2010/4/19 Michał Nazarewicz:
> Are you referring to my previous patch by saying "then they get tweaked
> to support a semi-dynamic state"? Those were just a proposal which was never
> accepted and suggested to remove those tags all together.

i'm referring to the change that started triggering these section
mismatch warnings with 2.6.33.  i dont recall seeing any such issues
with 2.6.28-2.6.32, and probably older as well.

>> sounds like the system is insufficiently flexible to meet the
>> realistic needs of different groups.
>
> Yes, I agree.  That's why in the first version I proposed the __usb_init,
> __usb_exit, etc. tags which could be customized prior to including
> composite related files.
>
> I would still go with that solution but it was considered, let me
> find the exact phrase, "Ick ick ick." :)

seems like __usbgadget_xxx would be better naming, but i'm not
interested in fighting to get the idea in general accepted

> What's more, I don't see any other (that is cleaner) solution which
> would allow flexibility so it seems what we can either choose
> a non-flexible solution proposed by this patch or an ugly solution
> proposed by my previous patch.

i dont have a problem with your current patch (since there are still
seciton mismatch warnings floating about that i imagine this is going
to fix), just with the general situation
-mike

  reply	other threads:[~2010-04-19  8:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-16  9:49 [PATCHv3 0/7] The FunctionFS composite function Michal Nazarewicz
2010-04-16  9:49 ` [PATCH 1/8] wait_event_interruptible_locked() interface Michal Nazarewicz
2010-04-16  9:49   ` [PATCH 2/8] fs/timerfd.c: make use of wait_event_interruptible_locked_irq() Michal Nazarewicz
2010-04-16  9:49     ` Michal Nazarewicz
2010-04-16  9:49     ` [PATCH 3/8] USB: gadget: __init and __exit tags removed Michal Nazarewicz
2010-04-16  9:49       ` [PATCH 4/8] USB: f_fs: the FunctionFS driver Michal Nazarewicz
2010-04-16  9:49         ` [PATCH 5/8] USB: g_ffs: the FunctionFS gadget driver Michal Nazarewicz
2010-04-16  9:49           ` [PATCH 6/8] USB: ffs-test: FunctionFS testing program Michal Nazarewicz
2010-04-16  9:49             ` [PATCH 7/8] USB: testusb: an USB testing application Michal Nazarewicz
2010-04-16  9:49               ` [PATCH 8/8] USB: testusb: testusb compatibility with FunctionFS gadget Michal Nazarewicz
2010-04-16 23:40       ` [PATCH 3/8] USB: gadget: __init and __exit tags removed Mike Frysinger
2010-04-19  7:57         ` Michał Nazarewicz
2010-04-19  8:02           ` Mike Frysinger [this message]
2010-04-19  9:04             ` Michał Nazarewicz
2010-04-16 16:10     ` [PATCH 2/8] fs/timerfd.c: make use of wait_event_interruptible_locked_irq() Davide Libenzi
2010-05-04 17:32 ` [PATCHv3 0/7] The FunctionFS composite function Greg KH
2010-05-04 17:32   ` Greg KH
2010-05-05  8:50   ` Michał Nazarewicz
2010-05-05  8:50     ` Michał Nazarewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=w2v8bd0f97a1004190102pd928e442td837c8fcee0541c5@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=greg@kroah.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.nazarewicz@samsung.com \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.