From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 383EDC43381 for ; Mon, 18 Jan 2021 14:52:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B56F22C7E for ; Mon, 18 Jan 2021 14:52:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405045AbhAROw1 (ORCPT ); Mon, 18 Jan 2021 09:52:27 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:38174 "EHLO mail-40131.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393075AbhAROwW (ORCPT ); Mon, 18 Jan 2021 09:52:22 -0500 Date: Mon, 18 Jan 2021 14:51:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1610981499; bh=qt2x5rgrpJue2xHPYqaQ4C7ABTsoce3bhOjz1FhicmU=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=pZBYgsbrcbcAlwRreIIzd7K09ne/a30fnt1I38L3S7wWkVfApM+oshWHpvErqPg1/ sL5OS3Y0TndIU3J3PtbU8x4FDmtwqkbU4uGotikqUVAdjhxSO82csOil4HEdw3zE4h d0JRD++/HF2CL+FmFYsPSOVDR0TDwMCMXIlrJCLQ= To: "andriy.shevchenko@linux.intel.com" From: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Cc: Daniel Scally , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "devel@acpica.org" , "rjw@rjwysocki.net" , "lenb@kernel.org" , "andy@kernel.org" , "mika.westerberg@linux.intel.com" , "linus.walleij@linaro.org" , "bgolaszewski@baylibre.com" , "wsa@kernel.org" , "lee.jones@linaro.org" , "hdegoede@redhat.com" , "mgross@linux.intel.com" , "robert.moore@intel.com" , "erik.kaneda@intel.com" , "sakari.ailus@linux.intel.com" , "laurent.pinchart@ideasonboard.com" , "kieran.bingham@ideasonboard.com" Reply-To: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Subject: Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver Message-ID: In-Reply-To: <20210118135121.GM4077@smile.fi.intel.com> References: <20210118003428.568892-1-djrscally@gmail.com> <20210118003428.568892-7-djrscally@gmail.com> <-GKrxu8GJvGe-PlKkLpblw9N-DtVtS7i87BOCLgJR72yf4hUFpUgiOlGcFero_gqgUxJrX2gxtLOnz_31hJugfam0SXXmXxIzGIhS162mhI=@protonmail.com> <20210118135121.GM4077@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org 2021. janu=C3=A1r 18., h=C3=A9tf=C5=91 14:51 keltez=C3=A9ssel, Andy Shevche= nko =C3=ADrta: > On Mon, Jan 18, 2021 at 11:12:34AM +0000, Barnab=C3=A1s P=C5=91cze wrote: > > 2021. janu=C3=A1r 18., h=C3=A9tf=C5=91 1:34 keltez=C3=A9ssel, Daniel Sc= ally =C3=ADrta: > > > Have you considered putting the source (and header) files into a dedica= ted > > folder? I think it'd help manageability in the long run, and it'd be im= mediately > > obvious that these source files form a single "unit". > > What would be the folder name? Because, for example, intel_cht_int33fe* h= ave no > folder (yet?) and here it's kinda similar case when HID describes somethi= ng > else than just one IP. I think "intel_skl_int3472" would not be a bad name for the folder. And I b= elieve "intel_cht_int33fe" could be given its own folder as well. Regards, Barnab=C3=A1s P=C5=91cze