From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DA76C4167B for ; Thu, 30 Nov 2023 21:43:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8ooM-0004Vh-VD; Thu, 30 Nov 2023 16:43:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8ooK-0004Uo-Uk for qemu-devel@nongnu.org; Thu, 30 Nov 2023 16:43:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8ooJ-0001o9-E8 for qemu-devel@nongnu.org; Thu, 30 Nov 2023 16:43:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701380582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MD69coIBlG9VqDYZ0wk5OAoCPvH1GgbHq/HJWPTguzs=; b=MR01+E3TAERnVS1O4MI7Cs14skM0ItGTeXgFl7wBTGFBbtuCzBxgsbT9SH9j2KtjIV7+wW Q6p77CRUvTcYTjXr+ifHKS1ruBf7kJlclOfQLNoKnqMbLQHWpG9l86TXp+nXOCQ31JD+U9 sYUGzWV5zZssEG2//XWl/EwT3EoNG/A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-hUhmXwXxNcmZVg8thDKODw-1; Thu, 30 Nov 2023 16:42:59 -0500 X-MC-Unique: hUhmXwXxNcmZVg8thDKODw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3DC1C811E7B; Thu, 30 Nov 2023 21:42:58 +0000 (UTC) Received: from redhat.com (unknown [10.2.16.190]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B96D210EA5; Thu, 30 Nov 2023 21:42:54 +0000 (UTC) Date: Thu, 30 Nov 2023 15:42:53 -0600 From: Eric Blake To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Hanna Reitz , Paul Durrant , Paolo Bonzini , Alberto Garcia , Emanuele Giuseppe Esposito , John Snow , Kevin Wolf , Wen Congyang , qemu-block@nongnu.org, xen-devel@lists.xenproject.org, Coiby Xu , Eduardo Habkost , Xie Changlong , Ari Sundholm , Li Zhijian , Cleber Rosa , Juan Quintela , "Michael S. Tsirkin" , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Jason Wang , Vladimir Sementsov-Ogievskiy , Zhang Chen , Peter Xu , Anthony Perard , Stefano Stabellini , Leonardo Bras , Pavel Dovgalyuk , Fam Zheng , Fabiano Rosas Subject: Re: [PATCH 08/12] aio: remove aio_context_acquire()/aio_context_release() API Message-ID: References: <20231129195553.942921-1-stefanha@redhat.com> <20231129195553.942921-9-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231129195553.942921-9-stefanha@redhat.com> User-Agent: NeoMutt/20231103 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Nov 29, 2023 at 02:55:49PM -0500, Stefan Hajnoczi wrote: > Delete these functions because nothing calls these functions anymore. > > I introduced these APIs in commit 98563fc3ec44 ("aio: add > aio_context_acquire() and aio_context_release()") in 2014. It's with a > sigh of relief that I delete these APIs almost 10 years later. > > Thanks to Paolo Bonzini's vision for multi-queue QEMU, we got an > understanding of where the code needed to go in order to remove the > limitations that the original dataplane and the IOThread/AioContext > approach that followed it. > > Emanuele Giuseppe Esposito had the splendid determination to convert > large parts of the codebase so that they no longer needed the AioContext > lock. This was a painstaking process, both in the actual code changes > required and the iterations of code review that Emanuele eeked out of s/eeked/eked/ > Kevin and me over many months. > > Kevin Wolf tackled multitudes of graph locking conversions to protect > in-flight I/O from run-time changes to the block graph as well as the > clang Thread Safety Analysis annotations that allow the compiler to > check whether the graph lock is being used correctly. > > And me, well, I'm just here to add some pizzazz to the QEMU multi-queue > block layer :). Thank you to everyone who helped with this effort, > including Eric Blake, code reviewer extraordinaire, and others who I've > forgotten to mention. > > Signed-off-by: Stefan Hajnoczi > --- > include/block/aio.h | 17 ----------------- > util/async.c | 10 ---------- > 2 files changed, 27 deletions(-) > Yay! Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org