From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59462)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1bL54P-0000xx-3i
	for qemu-devel@nongnu.org; Thu, 07 Jul 2016 04:54:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1bL54K-0005Ig-Ru
	for qemu-devel@nongnu.org; Thu, 07 Jul 2016 04:54:04 -0400
From: Alberto Garcia <berto@igalia.com>
In-Reply-To: <1467715800-20379-3-git-send-email-berrange@redhat.com>
References: <1467715800-20379-1-git-send-email-berrange@redhat.com>
	<1467715800-20379-3-git-send-email-berrange@redhat.com>
Date: Thu, 07 Jul 2016 10:53:59 +0200
Message-ID: <w517fcx7rrs.fsf@maestria.local.igalia.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v1 2/2] Revert "block: don't register
 quorum driver if SHA256 support is unavailable"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>

On Tue 05 Jul 2016 12:50:00 PM CEST, "Daniel P. Berrange" <berrange@redhat.com> wrote:
> The qcrypto hash APIs now guarantee that sha256 is available at
> compile time, so skipping registration is rarely needed. A check
> at time of open is kept to ensure good error reporting in the
> (unlikely) case sha256 is runtime disabled.
>
> This reverts commit e94867ed5f241008d0f53142b2704a075f9ed505.

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto