From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B44AAC432C0 for ; Mon, 25 Nov 2019 14:55:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82591207FD for ; Mon, 25 Nov 2019 14:55:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="pM+Ui1Vo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82591207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZFlb-0003L5-Mo for qemu-devel@archiver.kernel.org; Mon, 25 Nov 2019 09:55:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55048) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZFkb-0002oz-Cu for qemu-devel@nongnu.org; Mon, 25 Nov 2019 09:54:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZFka-0005TF-GD for qemu-devel@nongnu.org; Mon, 25 Nov 2019 09:54:05 -0500 Received: from fanzine.igalia.com ([178.60.130.6]:46063) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZFkW-0005Hv-6H; Mon, 25 Nov 2019 09:54:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=5iNGZpCh5XCYTmhdem00Fgqu1GTDvTuKUpZwTUAdKa8=; b=pM+Ui1VoT/iDG7hWvot7eIr+u2/y2/FtOY+fR9nIUeHi8LmmLq604Wz7omTrgEH9CiJ/0o+o8priEz3Z2MAzGeo5Xh/W5xGFA1rMefSBpiVitdbfkDqC2cjmEYwGJ4dQU+U+U4vexqIV4VlvMqIPavYmMAUCTQWLaAHGdbM74Y/DzX2UybQR404ppM92eBSkjD92lx9kVdTxPdnSz4bJNteoQPfACjOG6iLJcpAVoMMIxlYSz6ltQFgaBMewtr0r7R3pEMVKaD2B166w3AXmmIZHSeS1upA5DR/HTZnRfiOs7mtviJK/a+rgBQIeQ08BoG958L0oZy0sGb/Ni+dpfQ==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1iZFkD-0005pb-ET; Mon, 25 Nov 2019 15:53:41 +0100 Received: from berto by mail.igalia.com with local (Exim) id 1iZFkD-0000Oi-Bw; Mon, 25 Nov 2019 15:53:41 +0100 From: Alberto Garcia To: Kevin Wolf , qemu-block@nongnu.org Subject: Re: [PATCH v3 3/8] qcow2: Declare BDRV_REQ_NO_FALLBACK supported In-Reply-To: <20191122160511.8377-4-kwolf@redhat.com> References: <20191122160511.8377-1-kwolf@redhat.com> <20191122160511.8377-4-kwolf@redhat.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Mon, 25 Nov 2019 15:53:41 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 178.60.130.6 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri 22 Nov 2019 05:05:06 PM CET, Kevin Wolf wrote: > In the common case, qcow2_co_pwrite_zeroes() already only modifies > metadata case, so we're fine with or without BDRV_REQ_NO_FALLBACK set. > > The only exception is when using an external data file, where the > request is passed down to the block driver of the external data file. We > are forwarding the BDRV_REQ_NO_FALLBACK flag there, though, so this is > fine, too. > > Declare the flag supported therefore. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto