From: Alberto Garcia <berto@igalia.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Maor Lipchuk <mlipchuk@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
Nir Soffer <nsoffer@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 4/9] qcow2: make refcount size calculation conservative
Date: Mon, 08 May 2017 15:15:40 +0200 [thread overview]
Message-ID: <w51efvz32wz.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <20170418135726.28022-5-stefanha@redhat.com>
On Tue 18 Apr 2017 03:57:21 PM CEST, Stefan Hajnoczi wrote:
> The refcount metadata size calculation is inaccurate and can produce
> numbers that are too small. This is bad because we should calculate a
> conservative number - one that is guaranteed to be large enough.
>
> This patch switches the approach to a fixed point calculation because
> the existing equation is hard to solve when inaccuracies are taken care
> of.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
(I think I had already reviewed this in v4? I haven't seen any further
changes)
Berto
next prev parent reply other threads:[~2017-05-08 13:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 13:57 [Qemu-devel] [PATCH v5 0/9] qemu-img: add measure sub-command Stefan Hajnoczi
2017-04-18 13:57 ` [Qemu-devel] [PATCH v5 1/9] block: add bdrv_measure() API Stefan Hajnoczi
2017-04-18 15:08 ` Eric Blake
2017-04-19 13:27 ` Stefan Hajnoczi
2017-04-19 13:32 ` Eric Blake
2017-04-20 10:49 ` Stefan Hajnoczi
2017-04-18 13:57 ` [Qemu-devel] [PATCH v5 2/9] raw-format: add bdrv_measure() support Stefan Hajnoczi
2017-04-18 13:57 ` [Qemu-devel] [PATCH v5 3/9] qcow2: extract preallocation calculation function Stefan Hajnoczi
2017-04-18 13:57 ` [Qemu-devel] [PATCH v5 4/9] qcow2: make refcount size calculation conservative Stefan Hajnoczi
2017-05-08 13:15 ` Alberto Garcia [this message]
2017-04-18 13:57 ` [Qemu-devel] [PATCH v5 5/9] qcow2: extract image creation option parsing Stefan Hajnoczi
2017-04-18 13:57 ` [Qemu-devel] [PATCH v5 6/9] qcow2: add bdrv_measure() support Stefan Hajnoczi
2017-05-08 13:16 ` Alberto Garcia
2017-04-18 13:57 ` [Qemu-devel] [PATCH v5 7/9] qemu-img: add measure subcommand Stefan Hajnoczi
2017-05-08 14:17 ` Alberto Garcia
2017-04-18 13:57 ` [Qemu-devel] [PATCH v5 8/9] qemu-iotests: support per-format golden output files Stefan Hajnoczi
2017-05-08 13:18 ` Alberto Garcia
2017-04-18 13:57 ` [Qemu-devel] [PATCH v5 9/9] iotests: add test 178 for qemu-img measure Stefan Hajnoczi
2017-05-08 13:18 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51efvz32wz.fsf@maestria.local.igalia.com \
--to=berto@igalia.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mlipchuk@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.