All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alberto Garcia <berto@igalia.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 08/18] qcow: make encrypt_sectors encrypt in place
Date: Mon, 13 Feb 2017 11:47:56 +0100	[thread overview]
Message-ID: <w51inoez7s3.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <20170210170910.8867-9-berrange@redhat.com>

On Fri 10 Feb 2017 06:09:00 PM CET, Daniel P. Berrange wrote:
> Instead of requiring separate input/output buffers for
> encrypting data, change encrypt_sectors() to assume
> use of a single buffer, encrypting in place. One current
> caller uses the same buffer for input/output already
> and the other two callers are easily converted to do so.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

I think I had already reviewed this one in v3 :)

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto

  reply	other threads:[~2017-02-13 10:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-10 17:08 [Qemu-devel] [PATCH v4 00/18] Convert QCow[2] to QCryptoBlock & add LUKS support Daniel P. Berrange
2017-02-10 17:08 ` [Qemu-devel] [PATCH v4 01/18] block: expose crypto option names / defs to other drivers Daniel P. Berrange
2017-02-10 17:08 ` [Qemu-devel] [PATCH v4 02/18] block: add ability to set a prefix for opt names Daniel P. Berrange
2017-02-10 17:08 ` [Qemu-devel] [PATCH v4 03/18] qcow: document another weakness of qcow AES encryption Daniel P. Berrange
2017-02-10 17:08 ` [Qemu-devel] [PATCH v4 04/18] qcow: require image size to be > 1 for new images Daniel P. Berrange
2017-02-10 17:08 ` [Qemu-devel] [PATCH v4 05/18] iotests: skip 042 with qcow which dosn't support zero sized images Daniel P. Berrange
2017-02-10 17:08 ` [Qemu-devel] [PATCH v4 06/18] iotests: skip 048 with qcow which doesn't support resize Daniel P. Berrange
2017-02-10 17:08 ` [Qemu-devel] [PATCH v4 07/18] iotests: fix 097 when run with qcow Daniel P. Berrange
2017-02-10 17:09 ` [Qemu-devel] [PATCH v4 08/18] qcow: make encrypt_sectors encrypt in place Daniel P. Berrange
2017-02-13 10:47   ` Alberto Garcia [this message]
2017-02-10 17:09 ` [Qemu-devel] [PATCH v4 09/18] qcow: convert QCow to use QCryptoBlock for encryption Daniel P. Berrange
2017-02-13 14:53   ` Alberto Garcia
2017-02-10 17:09 ` [Qemu-devel] [PATCH v4 10/18] qcow2: make qcow2_encrypt_sectors encrypt in place Daniel P. Berrange
2017-02-10 17:09 ` [Qemu-devel] [PATCH v4 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption Daniel P. Berrange
2017-02-12  2:36   ` Max Reitz
2017-02-15 14:29   ` Alberto Garcia
2017-02-10 17:09 ` [Qemu-devel] [PATCH v4 12/18] qcow2: extend specification to cover LUKS encryption Daniel P. Berrange
2017-02-15 15:18   ` Alberto Garcia
2017-02-10 17:09 ` [Qemu-devel] [PATCH v4 13/18] qcow2: add support for LUKS encryption format Daniel P. Berrange
2017-02-16 13:42   ` Alberto Garcia
2017-02-20 18:18     ` Daniel P. Berrange
2017-02-10 17:09 ` [Qemu-devel] [PATCH v4 14/18] qcow2: add iotests to cover LUKS encryption support Daniel P. Berrange
2017-02-16 13:51   ` Alberto Garcia
2017-02-10 17:09 ` [Qemu-devel] [PATCH v4 15/18] iotests: enable tests 134 and 158 to work with qcow (v1) Daniel P. Berrange
2017-02-15 15:39   ` Alberto Garcia
2017-02-10 17:09 ` [Qemu-devel] [PATCH v4 16/18] block: rip out all traces of password prompting Daniel P. Berrange
2017-02-10 17:09 ` [Qemu-devel] [PATCH v4 17/18] block: remove all encryption handling APIs Daniel P. Berrange
2017-02-10 17:09 ` [Qemu-devel] [PATCH v4 18/18] block: pass option prefix down to crypto layer Daniel P. Berrange
2017-02-12  2:39   ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=w51inoez7s3.fsf@maestria.local.igalia.com \
    --to=berto@igalia.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.