From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtaiw-0004w1-OA for qemu-devel@nongnu.org; Tue, 12 Feb 2019 11:15:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtaaA-0000Ir-Tx for qemu-devel@nongnu.org; Tue, 12 Feb 2019 11:06:53 -0500 From: Alberto Garcia In-Reply-To: <20190212151558.GE5283@localhost.localdomain> References: <5c04485949b8cc3f63c6500b2bf6f70f4faaba4a.1547739122.git.berto@igalia.com> <20190212151558.GE5283@localhost.localdomain> Date: Tue, 12 Feb 2019 17:06:17 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 04/13] block: Freeze the backing chain for the duration of the stream job List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz On Tue 12 Feb 2019 04:15:58 PM CET, Kevin Wolf wrote: > Am 17.01.2019 um 16:33 hat Alberto Garcia geschrieben: >> Signed-off-by: Alberto Garcia >> --- >> block/stream.c | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/block/stream.c b/block/stream.c >> index 7a49ac0992..39a2e10892 100644 >> --- a/block/stream.c >> +++ b/block/stream.c >> @@ -54,6 +54,14 @@ static int coroutine_fn stream_populate(BlockBackend *blk, >> return blk_co_preadv(blk, offset, qiov.size, &qiov, BDRV_REQ_COPY_ON_READ); >> } >> >> +static void stream_abort(Job *job) >> +{ >> + StreamBlockJob *s = container_of(job, StreamBlockJob, common.job); >> + BlockJob *bjob = &s->common; >> + >> + bdrv_unfreeze_backing_chain(blk_bs(bjob->blk), s->base); >> +} > > Like in commit, you can get a double unfreeze here if .abort is called > after .prepare returned an error. You're right, I'll fix it Berto