All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alberto Garcia <berto@igalia.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 2/8] block: Drop useless bdrv_new() calls
Date: Tue, 01 Dec 2015 11:31:43 +0100	[thread overview]
Message-ID: <w51k2oyiho0.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <1447127063-4662-3-git-send-email-mreitz@redhat.com>

On Tue 10 Nov 2015 04:44:17 AM CET, Max Reitz wrote:
> bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS
> before invoking bdrv_open() on that BDS. This is probably a relict from
> when it used to do some modifications on that empty BDS, but now that is
> unnecessary, so we can just set bs_snapshot to NULL and let bdrv_open()
> do the rest.
>
> The same applies to bdrv_open_backing_file(). There is even a bit more
> cruft here: The assert() was intended for the BDS which is indirectly
> passed as the first bdrv_open() argument, so we can now drop it, too.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto

  reply	other threads:[~2015-12-01 10:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10  3:44 [Qemu-devel] [PATCH 0/8] blockdev: (Nearly) free clean-up work Max Reitz
2015-11-10  3:44 ` [Qemu-devel] [PATCH 1/8] qapi: Drop QERR_UNKNOWN_BLOCK_FORMAT_FEATURE Max Reitz
2015-11-10  3:59   ` Eric Blake
2015-12-01 10:17   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2015-11-10  3:44 ` [Qemu-devel] [PATCH 2/8] block: Drop useless bdrv_new() calls Max Reitz
2015-12-01 10:31   ` Alberto Garcia [this message]
2015-11-10  3:44 ` [Qemu-devel] [PATCH 3/8] block: Let bdrv_open_inherit() return the snapshot Max Reitz
2015-12-01 14:35   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2015-12-02 17:26     ` Max Reitz
2015-11-10  3:44 ` [Qemu-devel] [PATCH 4/8] block: Drop BB name from bad option error Max Reitz
2015-12-01 10:34   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2015-11-10  3:44 ` [Qemu-devel] [PATCH 5/8] block: Drop blk_new_with_bs() Max Reitz
2015-12-01 11:03   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2015-11-10  3:44 ` [Qemu-devel] [PATCH 6/8] block: Drop bdrv_new_root() Max Reitz
2015-12-01 11:04   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2015-11-10  3:44 ` [Qemu-devel] [PATCH 7/8] block: Make bdrv_open() return a BDS Max Reitz
2015-12-01 14:44   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2015-12-02 17:30     ` Max Reitz
2015-11-10  3:44 ` [Qemu-devel] [PATCH 8/8] block: Assert !bs->refcnt in bdrv_close() Max Reitz
2015-12-01 11:06   ` [Qemu-devel] [Qemu-block] " Alberto Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=w51k2oyiho0.fsf@maestria.local.igalia.com \
    --to=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.