From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3P5t-0007LP-7P for qemu-devel@nongnu.org; Mon, 30 Nov 2015 09:06:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3P5n-0004MZ-Uy for qemu-devel@nongnu.org; Mon, 30 Nov 2015 09:06:17 -0500 From: Alberto Garcia In-Reply-To: <1448294400-476-2-git-send-email-kwolf@redhat.com> References: <1448294400-476-1-git-send-email-kwolf@redhat.com> <1448294400-476-2-git-send-email-kwolf@redhat.com> Date: Mon, 30 Nov 2015 15:05:21 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 01/21] qcow2: Add .bdrv_join_options callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com On Mon 23 Nov 2015 04:59:40 PM CET, Kevin Wolf wrote: > qcow2 accepts a few driver-specific options that overlap semantically > (e.g. "overlap-check" is an alias of "overlap-check.template", and any > missing cache size option is derived from the given ones). > > When bdrv_reopen() merges the set of updated options with left out > options that should be kept at their old value, we need to consider this > and filter out any duplicates (which would generally cause errors > because new and old value would contradict each other). > > This patch adds a .bdrv_join_options callback to BlockDriver and > implements it for qcow2. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto