From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A74DC433E0 for ; Fri, 3 Jul 2020 15:25:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E20F4207D4 for ; Fri, 3 Jul 2020 15:25:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="qLqm6AXZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E20F4207D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrNYk-0003tn-P5 for qemu-devel@archiver.kernel.org; Fri, 03 Jul 2020 11:25:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrNUz-0008Iz-Q9; Fri, 03 Jul 2020 11:21:09 -0400 Received: from fanzine.igalia.com ([178.60.130.6]:55938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jrNUv-0004j7-Oi; Fri, 03 Jul 2020 11:21:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=KFe0EqMzbpxar1lOZNlogsRGzSKorOadmqr2nBKjLbg=; b=qLqm6AXZ59VwroPOaG4v6X9/VbUWtMEYC2ak8LCxbC3qrQTyNnnpHkmOnUB/YiXJLLVV0gBkCNswDCz79P1OO+0pJFku2efZV4ldwY2AXYXtbDA0v/4LHjwWmyMwH64SWoZ56Cf6jCbgjFUS/OfroXzdyT2tfZZymzkVeQOaiefPyYrBWeKWvr7Q6bBBrSHkoYmOiRwyNpDfvJHgwDVynX5y2D+VMm1RzLlY2ywszYtAksVqSTxZ0qM75MYRnjCndyHj7geqhJnhTlCQGx69J2RlhiJ0R1mNTXetSDTDNnm2YGOiMqkHo4MEM4A8LK+N2fljqaCD8lwvAXZV7TVaLw==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1jrNUp-0004aP-Ds; Fri, 03 Jul 2020 17:20:59 +0200 Received: from berto by mail.igalia.com with local (Exim) id 1jrNUp-0003e9-3y; Fri, 03 Jul 2020 17:20:59 +0200 From: Alberto Garcia To: Max Reitz , qemu-devel@nongnu.org Subject: Re: [PATCH v9 34/34] iotests: Add tests for qcow2 images with extended L2 entries In-Reply-To: <9afea208-5a07-4ef9-2cec-0ca1008e08b0@redhat.com> References: <536717bef174a2d5405647bf9ecf899e0aafadbb.1593342067.git.berto@igalia.com> <2a791051-5967-0279-75a1-4a44817b83b3@redhat.com> <9afea208-5a07-4ef9-2cec-0ca1008e08b0@redhat.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Fri, 03 Jul 2020 17:20:59 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=178.60.130.6; envelope-from=berto@igalia.com; helo=fanzine.igalia.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/03 11:21:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Derek Su , Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri 03 Jul 2020 03:47:41 PM CEST, Max Reitz wrote: >>>> + printf -v expected_bitmap "%llu" $expected_bitmap # Convert to un= signed >>> >>> Does the length modifier =E2=80=9Cll=E2=80=9D actually do anything? >>> >>>> + >>>> + printf "L2 entry #%d: 0x%016lx %016lx\n" "$entry_no" "$entry" "$b= itmap" >>> >>> Or the =E2=80=9Cl=E2=80=9D here? >>=20 >> Actually they don't (I just tested in i386 and x86_64), I assumed >> that it would require the length modifiers like in C. >>=20 >> I'm tempted to leave them for clarity (using 'll' in both cases), >> opinions? > > I don=E2=80=99t mind, although at least zsh=E2=80=99s printf doesn=E2=80= =99t seem to support > them all: > > $ printf %lli 42 > printf: %ll: invalid directive I went to the bash source code, and it seems that the length modifiers are simply skipped: https://git.savannah.gnu.org/cgit/bash.git/tree/builtins/printf.def#n412 I'll remove them then. Berto