All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alberto Garcia <berto@igalia.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 14/15] block: Remove assertions from update_flags_from_options()
Date: Mon, 12 Nov 2018 11:26:11 +0100	[thread overview]
Message-ID: <w51muqebni4.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <62cb7e48-9120-ace4-cd84-f462b3100251@redhat.com>

On Sun 11 Nov 2018 10:01:05 PM CET, Max Reitz wrote:
> On 07.11.18 13:59, Alberto Garcia wrote:
>> This function takes three options (cache.direct, cache.no-flush and
>> read-only) from a QemuOpts object and updates the flags accordingly.
>
> and auto-read-only now

Oops, will update.

> Hm, seems like one way to solve it and I can't really find issue with
> it.  So, let's first give a
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
>
> However, I wonder why you dropped your patch from v1 for this.  It
> seemed more reasonable to me.  You're basically trading half-updating
> the flags for just not touching them at all (and the latter seems
> better, even though it's all an error in the end anyway).

The main reason why I'm doing this is because if we keep the assertions
then we're forced to have these four options always set, and I don't see
any reason why they would need to be.

It's not a problem now but it will be later on. Have a look at this
early implementation of qmp_x_blockdev_reopen():

   https://lists.gnu.org/archive/html/qemu-block/2018-06/msg00795.html

Here we need to explicitly set those options to false if they're
unset. 'false' is already the default value of all of them, so this
shouldn't be necessary, but if we don't do it we'd hit the assertions
that I'm removing in this patch.

Berto

  reply	other threads:[~2018-11-12 10:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07 12:59 [Qemu-devel] [PATCH v4 00/15] Don't pass flags to bdrv_reopen_queue() Alberto Garcia
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 01/15] block: Add bdrv_reopen_set_read_only() Alberto Garcia
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 02/15] block: Use bdrv_reopen_set_read_only() in bdrv_backing_update_filename() Alberto Garcia
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 03/15] block: Use bdrv_reopen_set_read_only() in commit_start/complete() Alberto Garcia
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 04/15] block: Use bdrv_reopen_set_read_only() in bdrv_commit() Alberto Garcia
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 05/15] block: Use bdrv_reopen_set_read_only() in stream_start/complete() Alberto Garcia
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 06/15] block: Use bdrv_reopen_set_read_only() in qmp_change_backing_file() Alberto Garcia
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 07/15] block: Use bdrv_reopen_set_read_only() in external_snapshot_commit() Alberto Garcia
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 08/15] block: Use bdrv_reopen_set_read_only() in the mirror driver Alberto Garcia
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 09/15] block: Drop bdrv_reopen() Alberto Garcia
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 10/15] qemu-io: Put flag changes in the options QDict in reopen_f() Alberto Garcia
2018-11-11 20:28   ` Max Reitz
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 11/15] block: Clean up reopen_backing_file() in block/replication.c Alberto Garcia
2018-11-11 20:31   ` Max Reitz
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 12/15] block: Remove flags parameter from bdrv_reopen_queue() Alberto Garcia
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 13/15] block: Stop passing flags to bdrv_reopen_queue_child() Alberto Garcia
2018-11-11 20:47   ` Max Reitz
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 14/15] block: Remove assertions from update_flags_from_options() Alberto Garcia
2018-11-11 21:01   ` Max Reitz
2018-11-12 10:26     ` Alberto Garcia [this message]
2018-11-12 15:20       ` Max Reitz
2018-11-12 10:36     ` Alberto Garcia
2018-11-07 12:59 ` [Qemu-devel] [PATCH v4 15/15] block: Assert that flags are up-to-date in bdrv_reopen_prepare() Alberto Garcia
2018-11-11 21:06   ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=w51muqebni4.fsf@maestria.local.igalia.com \
    --to=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.