From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91BDFC2BA19 for ; Tue, 14 Apr 2020 16:18:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5649620678 for ; Tue, 14 Apr 2020 16:18:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="Pju2Drp/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5649620678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOH1-0005Rt-DZ for qemu-devel@archiver.kernel.org; Tue, 14 Apr 2020 12:18:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49783) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOFF-0004Jh-R5 for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:17:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOOFA-00048i-A2 for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:17:05 -0400 Received: from fanzine.igalia.com ([178.60.130.6]:36226) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOOF9-00047z-OA; Tue, 14 Apr 2020 12:17:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=KMhVJnl1t+vI+3Es4o58nmfl88f8zgNM9txq68QwWOM=; b=Pju2Drp/Nr0Z2p9qlS9eVpMtNU3A/7wdubqOlMu0W73sMY3wbQGm3GTJ8vsLvNDdHKjihIUAvteGftEce9tTSkSR5aFo91b53bw24K5mBXLXoE0zGzXEfRbxGBNwhYZkgNsMZum7/1QnIYOm/LLwHlrG+DM8XFbAoAd+8Dzhp/zdB9T9aaoBYdbjZNPOgvCkGz9Ko/vQICofrmJdjFMd66N5TrBkpNwYHStgHNqUI2jV5LimMFQRHJRpl7cAV0JpDG3df3HjHevonepitDueuC6ma+u8hdxoq92d43R56NtNqhBmKPHf6UshCrnYMAzncZxHI4TPtr7+PY79A20j+A==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1jOOF4-00088q-OH; Tue, 14 Apr 2020 18:16:54 +0200 Received: from berto by mail.igalia.com with local (Exim) id 1jOOF4-0004zk-Eh; Tue, 14 Apr 2020 18:16:54 +0200 From: Alberto Garcia To: Eric Blake , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Subject: Re: [PATCH v4 11/30] qcow2: Add l2_entry_size() In-Reply-To: <81446480-40cc-3e6f-ac0f-8b18422ae9f4@redhat.com> References: <58d1fa17-91ea-9f8d-c39a-4141783d1234@virtuozzo.com> <81446480-40cc-3e6f-ac0f-8b18422ae9f4@redhat.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Tue, 14 Apr 2020 18:16:54 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 178.60.130.6 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Denis V . Lunev" , Anton Nefedov , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue 14 Apr 2020 06:01:42 PM CEST, Eric Blake wrote: >>> And all occurrences of pure '8' (not many of them exist) >> >> I think most/all nowadays only refer to the number of bits per byte. > > CHAR_BIT (from ) is good for that. Wow, ok, I wonder if that actually makes the code more readable, but I'll take it into account when writing the patch, thanks. Berto