From: Alberto Garcia <berto@igalia.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, jcody@redhat.com,
mreitz@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter
Date: Fri, 08 Feb 2019 14:13:32 +0100 [thread overview]
Message-ID: <w51o97m8ltv.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <1548244464-633186-1-git-send-email-andrey.shinkevich@virtuozzo.com>
On Wed 23 Jan 2019 12:54:24 PM CET, Andrey Shinkevich wrote:
> +static BlockDriverState *insert_filter(BlockDriverState *bs, Error **errp)
> +{
> + BlockDriverState *cor_filter_bs;
> + Error *local_err = NULL;
> +
> + cor_filter_bs = create_filter_node(bs, errp);
> + if (cor_filter_bs == NULL) {
> + error_prepend(errp, "Could not create filter node: ");
> + return NULL;
> + }
> +
> + bdrv_set_aio_context(cor_filter_bs, bdrv_get_aio_context(bs));
> +
> + bdrv_drained_begin(bs);
> + bdrv_replace_node(bs, cor_filter_bs, &local_err);
> + bdrv_drained_end(bs);
I think this was already discussed in the previous version of this
patch: if you insert a copy-on-read filter here then all guest reads
will copy the data from the backing chain, but you don't want to copy
anything below the 'base' node, so the copy-on-read filter needs a
'base' parameter.
Berto
next prev parent reply other threads:[~2019-02-08 13:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 11:54 [Qemu-devel] [PATCH RFC 1/1] Stream block job involves copy-on-read filter Andrey Shinkevich
2019-01-23 13:10 ` Vladimir Sementsov-Ogievskiy
2019-01-31 14:02 ` Andrey Shinkevich
2019-02-08 13:13 ` Alberto Garcia [this message]
2019-02-08 15:29 ` [Qemu-devel] [Qemu-block] " Andrey Shinkevich
2019-02-11 14:07 ` Alberto Garcia
2019-02-11 14:51 ` Vladimir Sementsov-Ogievskiy
2019-02-11 15:52 ` Alberto Garcia
2019-02-11 16:58 ` Vladimir Sementsov-Ogievskiy
2019-02-12 11:35 ` Alberto Garcia
2019-02-14 13:43 ` Andrey Shinkevich
2019-02-18 10:08 ` Vladimir Sementsov-Ogievskiy
2019-02-20 9:10 ` Andrey Shinkevich
2019-02-11 14:54 ` Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51o97m8ltv.fsf@maestria.local.igalia.com \
--to=berto@igalia.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=den@openvz.org \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.