All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alberto Garcia <berto@igalia.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables
Date: Tue, 29 Aug 2017 15:12:24 +0200	[thread overview]
Message-ID: <w51pobefrgn.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <9c225c3c-e21c-48ad-ac36-e472c6dec84a@amsat.org>

On Tue 29 Aug 2017 02:31:35 PM CEST, Philippe Mathieu-Daudé wrote:

>> There's a few cases which we're passing an Error pointer to a function
>> only to discard it immediately afterwards without checking it. In
>> these cases we can simply remove the variable and pass NULL instead.
>
> How did you notice?

I noticed it while I was working on something else. It's also not the
first time I see something like this (see e.g. 026ac1586bdbd184e240).

Berto

  reply	other threads:[~2017-08-29 13:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 12:08 [Qemu-devel] [PATCH] misc: Remove unused Error variables Alberto Garcia
2017-08-29 12:31 ` Philippe Mathieu-Daudé
2017-08-29 13:12   ` Alberto Garcia [this message]
2017-08-29 14:40 ` Eric Blake
2017-08-29 14:45   ` Alberto Garcia
2017-08-30 10:59 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=w51pobefrgn.fsf@maestria.local.igalia.com \
    --to=berto@igalia.com \
    --cc=f4bug@amsat.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.