From: Alberto Garcia <berto@igalia.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 2/2] block: Make bdrv_root_attach_child() unref child_bs on failure
Date: Mon, 13 May 2019 17:52:56 +0200 [thread overview]
Message-ID: <w51r292pd0n.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <5783a050-5866-80d5-4699-7ea0bf122398@redhat.com>
On Mon 13 May 2019 04:31:16 PM CEST, Max Reitz wrote:
>> @@ -2569,10 +2582,6 @@ BdrvChild *bdrv_open_child(const char *filename,
>> }
>>
>> c = bdrv_attach_child(parent, bs, bdref_key, child_role, errp);
>> - if (!c) {
>> - bdrv_unref(bs);
>> - return NULL;
>> - }
>>
>> return c;
>> }
>
> (That could have been simplified even further. *shrug*)
Right, we can remove the 'c' variable altogether. Feel free to edit the
commit if you want.
Berto
next prev parent reply other threads:[~2019-05-13 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 13:46 [Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close() Alberto Garcia
2019-05-13 13:46 ` [Qemu-devel] [PATCH v3 1/2] " Alberto Garcia
2019-05-23 15:27 ` Alberto Garcia
2019-05-23 15:57 ` Max Reitz
2019-05-13 13:46 ` [Qemu-devel] [PATCH v3 2/2] block: Make bdrv_root_attach_child() unref child_bs on failure Alberto Garcia
2019-05-13 14:31 ` Max Reitz
2019-05-13 15:52 ` Alberto Garcia [this message]
2019-05-13 15:54 ` Max Reitz
2019-05-13 14:32 ` [Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close() Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51r292pd0n.fsf@maestria.local.igalia.com \
--to=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.