All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alberto Garcia <berto@igalia.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Nini Gu <ngu@redhat.com>, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 2/3] throttle: do not use invalid config in test
Date: Wed, 01 Mar 2017 13:29:58 +0100	[thread overview]
Message-ID: <w51tw7dnprt.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <20170301115026.22621-3-stefanha@redhat.com>

On Wed 01 Mar 2017 12:50:25 PM CET, Stefan Hajnoczi wrote:
> The (burst) max parameter cannot be smaller than the avg parameter.
> There is a test case that uses avg = 56, max = 1 and gets away with it
> because no input validation is performed by the test case.
>
> This patch switches to valid test input parameters.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto

  reply	other threads:[~2017-03-01 12:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01 11:50 [Qemu-devel] [PATCH v3 0/3] throttle: improve command-line parameter documentation Stefan Hajnoczi
2017-03-01 11:50 ` [Qemu-devel] [PATCH v3 1/3] qemu-options: explain disk I/O throttling options Stefan Hajnoczi
2017-03-01 13:07   ` Alberto Garcia
2017-03-01 21:29   ` Greg Kurz
2017-03-01 11:50 ` [Qemu-devel] [PATCH v3 2/3] throttle: do not use invalid config in test Stefan Hajnoczi
2017-03-01 12:29   ` Alberto Garcia [this message]
2017-03-01 11:50 ` [Qemu-devel] [PATCH v3 3/3] throttle: make throttle_config(throttle_get_config()) symmetric Stefan Hajnoczi
2017-03-01 12:30   ` Alberto Garcia
2017-03-01 21:27 ` [Qemu-devel] [PATCH v3 0/3] throttle: improve command-line parameter documentation Greg Kurz
2017-03-03  2:11   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-03  7:01     ` Greg Kurz
2017-03-03  2:21 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=w51tw7dnprt.fsf@maestria.local.igalia.com \
    --to=berto@igalia.com \
    --cc=ngu@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.