From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD78C2BA19 for ; Tue, 14 Apr 2020 12:35:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8781C206D5 for ; Tue, 14 Apr 2020 12:35:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="qL0uUcFP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8781C206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOKmP-0000lY-No for qemu-devel@archiver.kernel.org; Tue, 14 Apr 2020 08:35:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34154) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOKlK-0008HT-VR for qemu-devel@nongnu.org; Tue, 14 Apr 2020 08:34:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOKlJ-0001bv-UQ for qemu-devel@nongnu.org; Tue, 14 Apr 2020 08:33:58 -0400 Received: from fanzine.igalia.com ([178.60.130.6]:43686) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOKlJ-0001bR-DY; Tue, 14 Apr 2020 08:33:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=woZ74ZHuqjXIPXGAXK3DrAT2/QKm7IJRkZ0y6rGxAYQ=; b=qL0uUcFPL67aweIRioRCxHrqamCf/8Bj90eRp8q4Ge3CtvR+HTUfvmUzE9N69YtIhQATdkwiZL9sDC+Erj3331kuu5gfHROmV9/wOlROLNnLIrwqCpSnNCcqKSFo9aOezm1/7Qg3RFihWtQH5dUkVXL06J79vG7xm5S48vgs2kXHJux4keT+O9C9PTPOzyfJU/C4Rj63iUIGc0ac8B1SIEHmEYe7ZjvNaQWLdP7qjdSAYrHfS/FWHMMv2hnae52mhdFkpt8soPYZkhK+SSOmWC3vyVeIUdZti+bv9rRa+B+a+4gsH1D+yB2HU1bZrdcIHCiXP0HSTJGh02xfOySikA==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1jOKlG-0004cZ-Kl; Tue, 14 Apr 2020 14:33:54 +0200 Received: from berto by mail.igalia.com with local (Exim) id 1jOKlG-000323-B1; Tue, 14 Apr 2020 14:33:54 +0200 From: Alberto Garcia To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Subject: Re: [PATCH v4 11/30] qcow2: Add l2_entry_size() In-Reply-To: <9695a347-b490-12b2-8a01-09ad8bdb8eb9@virtuozzo.com> References: <58d1fa17-91ea-9f8d-c39a-4141783d1234@virtuozzo.com> <9695a347-b490-12b2-8a01-09ad8bdb8eb9@virtuozzo.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Tue, 14 Apr 2020 14:33:54 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 178.60.130.6 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Anton Nefedov , qemu-block@nongnu.org, Max Reitz , "Denis V . Lunev" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue 14 Apr 2020 02:29:13 PM CEST, Vladimir Sementsov-Ogievskiy wrote: >>> Hmm. How to avoid it? Maybe, at least, refactor the code, to drop all >>> sizeof(uint64_t), converting them to L2_ENTRY_SIZE, L1_ENTRY_SIZE, >>> REFTABLE_ENTRY_SIZE etc? >> >> That wouldn't be a bad thing I guess but, again, for a separate patch or >> series. >> >>> And all occurrences of pure '8' (not many of them exist) >> >> I think most/all nowadays only refer to the number of bits per byte. >> >> Maybe there's a couple that still need to be fixed, but we have been >> removing a lot of numeric literals from the qcow2 code (see for example >> b6c246942b, 3afea40243 or a35f87f50d). >> > > > git grep '\<8\>' block/qcow2* > > shows at least > > qcow2-cluster.c: s->l1_table_offset + 8 * l1_start_index, bufsize, false); > qcow2-cluster.c: s->l1_table_offset + 8 * l1_start_index, I see, worth replacing with L1_ENTRY_SIZE as you suggest. I can take of writing the patches if you want. Berto