From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FB6C54FD0 for ; Thu, 23 Apr 2020 16:52:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7FC220715 for ; Thu, 23 Apr 2020 16:52:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="Wf+CkQgF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7FC220715 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRe4W-0004lZ-4r for qemu-devel@archiver.kernel.org; Thu, 23 Apr 2020 11:47:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57342) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRe32-0002vR-Mx for qemu-devel@nongnu.org; Thu, 23 Apr 2020 11:45:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRe31-0006qS-ST for qemu-devel@nongnu.org; Thu, 23 Apr 2020 11:45:56 -0400 Received: from fanzine.igalia.com ([178.60.130.6]:40917) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRe30-0006bN-WD; Thu, 23 Apr 2020 11:45:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=ThxkYpu0m025sAoAV+c74k1GqC7O9yRA28t0Rb56NTQ=; b=Wf+CkQgFaH9amzvgmBQz/BXB/vnZrejnE1UQSZ6tZ2tKMdWtOEI8dMhRQU5t1P4e2cbXnkq61Ru8sLIMQhPVuab8Gq8tbIq1mv6YBrP+R539lCXO0uN5rUnXaf9O0lQvDBIt6IfqqG+3Uwh920Wt/NVjAW2UolIf0ZQAs8ddKmbhyAIT2vskmCZayY6xGUPChIusmt4ll0GFQtocBtlK+xiSerAIrAkVX0Xglb/sSMetWACylh/lQXnkfvmq52a3LGidqSjJpb0Rlk57eMdXrpzMAewuZ+icCuNZJXsZHOwlJKI2RwEmboeIDaeQWyxuoWq54U0ONa7SlBWc51AalA==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine.igalia.com with esmtps (Cipher TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim) id 1jRe2v-00087I-4K; Thu, 23 Apr 2020 17:45:49 +0200 Received: from berto by mail.igalia.com with local (Exim) id 1jRe2u-0005tH-RF; Thu, 23 Apr 2020 17:45:48 +0200 From: Alberto Garcia To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Subject: Re: [PATCH v4 21/30] qcow2: Add subcluster support to check_refcounts_l2() In-Reply-To: <9972aadc-dcc8-9fce-019b-e23d2b7dcad8@virtuozzo.com> References: <9972aadc-dcc8-9fce-019b-e23d2b7dcad8@virtuozzo.com> User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Thu, 23 Apr 2020 17:45:48 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=178.60.130.6; envelope-from=berto@igalia.com; helo=fanzine.igalia.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/23 10:18:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 178.60.130.6 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Anton Nefedov , qemu-block@nongnu.org, Max Reitz , "Denis V . Lunev" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed 22 Apr 2020 02:06:56 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > 17.03.2020 21:16, Alberto Garcia wrote: >> Setting the QCOW_OFLAG_ZERO bit of the L2 entry is forbidden if an >> image has subclusters. Instead, the individual 'all zeroes' bits must >> be used. >> >> Signed-off-by: Alberto Garcia >> Reviewed-by: Max Reitz > > Patch itself seems correct.. Still, would be good also to check, is > QCOW_OFLAG_ZERO set in subclustres case and add corresponding > corruptions++, and may be even fix (by using > QCOW_L2_BITMAP_ALL_ZEROES instead) I'll add it to my TODO list for a later patch. Berto