From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Machata Subject: Re: [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by_user FDB entries Date: Thu, 03 May 2018 16:07:18 +0300 Message-ID: References: <33ac8ce3fcd084190c5797a409ebd7858f7d47db.1525350809.git.petrm@mellanox.com> <39b65224-cd35-4716-1a8c-cc1bfaff0654@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, jiri@mellanox.com, idosch@mellanox.com, ivecera@redhat.com, davem@davemloft.net, stephen@networkplumber.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com To: Nikolay Aleksandrov Return-path: Received: from mail-he1eur01on0056.outbound.protection.outlook.com ([104.47.0.56]:40501 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750871AbeECNHk (ORCPT ); Thu, 3 May 2018 09:07:40 -0400 In-Reply-To: <39b65224-cd35-4716-1a8c-cc1bfaff0654@cumulusnetworks.com> (Nikolay Aleksandrov's message of "Thu, 3 May 2018 15:56:33 +0300") Sender: netdev-owner@vger.kernel.org List-ID: Nikolay Aleksandrov writes: > On 03/05/18 15:43, Petr Machata wrote: >> Do not automatically bail out on sending notifications about activity on >> non-user-added FDB entries. Instead, notify about this activity except >> for cases where the activity itself originates in a notification, to >> avoid sending duplicate notifications. >> >> Signed-off-by: Petr Machata >> --- >> net/bridge/br.c | 4 ++-- >> net/bridge/br_fdb.c | 47 ++++++++++++++++++++++++++--------------------- >> net/bridge/br_private.h | 6 ++++-- >> net/bridge/br_switchdev.c | 2 +- >> 4 files changed, 33 insertions(+), 26 deletions(-) >> > > Thanks, looks good to me! In the future please add the reviewers to the CC list > when sending a v2, I actually missed the v2 set and saw your reply to the cover > letter patch later. Sorry, I'm still tweaking my process for direct submission after going almost exclusively through mlxsw for so long! > Acked-by: Nikolay Aleksandrov Thanks, Petr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AIhvcSe+3hgYUQ9mZn94AQB7Y1lvzZAGR9g/6sIliFY=; b=n1RBZjkJTjvEuNvSLBmkZjhMrY+sWFziSJeWP39/pxGWuAMiBOQ8fQu8WvUrn8mR6L6j6MXzzNpo9Uer2+rtwhp3F8NN07T3FVJANacLzj4snwqJ9y4YGgSr5yt2+ImIh7zgzuZicCUHGIfXvNJNBHB2ZI8vxY7z54sJr8fBgQI= From: Petr Machata References: <33ac8ce3fcd084190c5797a409ebd7858f7d47db.1525350809.git.petrm@mellanox.com> <39b65224-cd35-4716-1a8c-cc1bfaff0654@cumulusnetworks.com> Date: Thu, 03 May 2018 16:07:18 +0300 In-Reply-To: <39b65224-cd35-4716-1a8c-cc1bfaff0654@cumulusnetworks.com> (Nikolay Aleksandrov's message of "Thu, 3 May 2018 15:56:33 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Bridge] [PATCH net-next mlxsw v2 2/2] net: bridge: Notify about !added_by_user FDB entries List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikolay Aleksandrov Cc: ivecera@redhat.com, f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, idosch@mellanox.com, jiri@mellanox.com, vivien.didelot@savoirfairelinux.com, davem@davemloft.net Nikolay Aleksandrov writes: > On 03/05/18 15:43, Petr Machata wrote: >> Do not automatically bail out on sending notifications about activity on >> non-user-added FDB entries. Instead, notify about this activity except >> for cases where the activity itself originates in a notification, to >> avoid sending duplicate notifications. >> >> Signed-off-by: Petr Machata >> --- >> net/bridge/br.c | 4 ++-- >> net/bridge/br_fdb.c | 47 ++++++++++++++++++++++++++--------------------- >> net/bridge/br_private.h | 6 ++++-- >> net/bridge/br_switchdev.c | 2 +- >> 4 files changed, 33 insertions(+), 26 deletions(-) >> > > Thanks, looks good to me! In the future please add the reviewers to the CC list > when sending a v2, I actually missed the v2 set and saw your reply to the cover > letter patch later. Sorry, I'm still tweaking my process for direct submission after going almost exclusively through mlxsw for so long! > Acked-by: Nikolay Aleksandrov Thanks, Petr