All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: Geliang Tang <geliangtang@163.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"devel\@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning
Date: Mon, 15 Feb 2016 10:43:21 -0500	[thread overview]
Message-ID: <wrfjoabivv1i.fsf@redhat.com> (raw)
In-Reply-To: <CAGRGNgXDQXPOydOh_TFmJX=0sMVtwkb_XpOJx3CrjXfRopYJ4Q@mail.gmail.com> (Julian Calaby's message of "Mon, 8 Feb 2016 09:17:22 +1100")

Julian Calaby <julian.calaby@gmail.com> writes:
> Hi Geliang,
>
> On Sun, Feb 7, 2016 at 2:30 PM, Geliang Tang <geliangtang@163.com> wrote:
>> This patch cleans whitespaces and blank lines surrounding
>> list_for_each_entry*().
>
> It does a lot more than this, including:
>  - Removing some unnecessary brackets
>  - Whitespace changes well away from the list_for_each_entry*() calls
>
> You need to either specify all of these in the changelog or split it
> up into multiple patches.
>
> Thanks,
>
> Julian Calaby

I agree, I think a more descriptive patch message will suffice here.

Jes

  reply	other threads:[~2016-02-15 15:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-31 15:47 [PATCH] staging: rtl8723au: use list_for_each_entry*() Geliang Tang
2016-01-31 17:49 ` Jes Sorensen
2016-02-01 14:10   ` [PATCH v2] " Geliang Tang
2016-02-02 20:30     ` Jes Sorensen
2016-02-07  3:29       ` [PATCH v3 1/3] " Geliang Tang
2016-02-07  3:29         ` [PATCH v3 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Geliang Tang
2016-02-07  3:30           ` [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning Geliang Tang
2016-02-07 22:17             ` Julian Calaby
2016-02-15 15:43               ` Jes Sorensen [this message]
2016-02-15 15:33           ` [PATCH v3 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Jes Sorensen
2016-02-15 15:32         ` [PATCH v3 1/3] staging: rtl8723au: use list_for_each_entry*() Jes Sorensen
2016-02-17 13:48           ` [PATCH v4 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning Geliang Tang
2016-02-17 13:48             ` [PATCH v4 1/3] staging: rtl8723au: use list_for_each_entry*() Geliang Tang
2016-02-17 13:48               ` [PATCH v4 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Geliang Tang
2016-02-17 13:48                 ` [PATCH v4 3/3] staging: rtl8723au: whitespace and blank line cleaning Geliang Tang
2016-02-17 15:16               ` [PATCH v4 1/3] staging: rtl8723au: use list_for_each_entry*() kbuild test robot
2016-02-17 17:28                 ` Jes Sorensen
2016-02-18 14:19                   ` [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning Geliang Tang
2016-02-18 14:19                     ` [PATCH v5 1/3] staging: rtl8723au: use list_for_each_entry*() Geliang Tang
2016-02-18 14:19                       ` [PATCH v5 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes Geliang Tang
2016-02-18 14:19                         ` [PATCH v5 3/3] staging: rtl8723au: whitespace and blank line cleaning Geliang Tang
2016-02-18 19:09                     ` [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjoabivv1i.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=geliangtang@163.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=julian.calaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.