From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: "Kershner, David A" <David.Kershner@unisys.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
*S-Par-Maintainer <SParMaintainer@unisys.com>,
"driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>,
"Romer, Benjamin M" <Benjamin.Romer@unisys.com>
Subject: Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed
Date: Fri, 19 Jun 2015 11:08:46 -0400 [thread overview]
Message-ID: <wrfjvbejburl.fsf@redhat.com> (raw)
In-Reply-To: <a7af1243b7c54a438047cea243d91381@US-EXCH13-1.na.uis.unisys.com> (David A. Kershner's message of "Fri, 19 Jun 2015 15:02:32 +0000")
"Kershner, David A" <David.Kershner@unisys.com> writes:
>> -----Original Message-----
>> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
>> Sent: Friday, June 19, 2015 8:55 AM
>> To: Kershner, David A
>> Cc: gregkh@linuxfoundation.org; Jes.Sorensen@redhat.com; *S-Par-
>> Maintainer; driverdev-devel@linuxdriverproject.org; Romer, Benjamin M
>> Subject: Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to
>> __packed
>>
>> On Fri, Jun 12, 2015 at 04:46:07PM -0400, David Kershner wrote:
>> > It was noticed that iochannel.h was still using pragmas to
>> > pack the datastructures, should be using __packed instead.
>> >
>> > Signed-off-by: David Kershner <david.kershner@unisys.com>
>>
>> Could you take some time and figure out which structs should actually
>> be packed and which should not? For example, in net_pkt_rcv the
>> pointers are not aligned so it will cause a slow down on x86 and crash
>> on other arches (which we don't care about).
>>
>> regards,
>> dan carpenter
>
> Dan,
>
> Thanks for the find. Unfortunately, all the structs defined in iochannel.h
> need to be packed since they are shared across different OS and code
> instances. I'll look into changing the s-Par firmware and will update the
> iochannels structure as well.
>
> Your reference to x86, does that include x86_64?
Not sure how the firmware interface is, but I hope you can version tag
it so the OS can know when to do what?
Cheers,
Jes
next prev parent reply other threads:[~2015-06-19 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 20:46 [PATCH v2 0/3] staging: unisys: visorbus fixes David Kershner
2015-06-12 20:46 ` [PATCH v2 1/3] staging: unisys: Move phys_info to iochannel.h David Kershner
2015-06-12 20:46 ` [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed David Kershner
2015-06-13 0:07 ` Greg KH
2015-06-19 12:55 ` Dan Carpenter
2015-06-19 15:02 ` Kershner, David A
2015-06-19 15:08 ` Jes Sorensen [this message]
2015-06-19 19:11 ` Dan Carpenter
2015-06-12 20:46 ` [PATCH v2 3/3] staging: unisys: Don't hold device responses until driver loads David Kershner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjvbejburl.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Benjamin.Romer@unisys.com \
--cc=David.Kershner@unisys.com \
--cc=SParMaintainer@unisys.com \
--cc=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.