From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753763AbaGJPL7 (ORCPT ); Thu, 10 Jul 2014 11:11:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22616 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517AbaGJPL6 (ORCPT ); Thu, 10 Jul 2014 11:11:58 -0400 From: Jeff Moyer To: Benjamin LaHaise Cc: "Elliott\, Robert \(Server Storage\)" , Jens Axboe , Christoph Hellwig , "dgilbert\@interlog.com" , James Bottomley , Bart Van Assche , "linux-scsi\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: Re: scsi-mq V2 References: <1403715121-1201-1-git-send-email-hch@lst.de> <20140708144829.GA5539@infradead.org> <53BD7041.5010300@interlog.com> <53BD9A24.7010203@kernel.dk> <94D0CD8314A33A4D9D801C0FE68B402958B9628B@G9W0745.americas.hpqcorp.net> <20140710062040.GB20146@infradead.org> <20140710133609.GO12478@kvack.org> <20140710135051.GA28227@infradead.org> <53BE9AB1.6090603@kernel.dk> <94D0CD8314A33A4D9D801C0FE68B402958B96CF0@G9W0745.americas.hpqcorp.net> <20140710144539.GU12478@kvack.org> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Thu, 10 Jul 2014 11:11:10 -0400 In-Reply-To: <20140710144539.GU12478@kvack.org> (Benjamin LaHaise's message of "Thu, 10 Jul 2014 10:45:39 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Benjamin LaHaise writes: >> >> [ 186.339064] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >> [ 186.339065] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >> [ 186.339067] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >> [ 186.339068] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >> [ 186.339069] ioctx_alloc: nr_events=-2 aio_max_nr=65536 > > Something is horribly wrong here. There is no way that value for nr_events > should be passed in to ioctx_alloc(). This implies that userland is calling > io_setup() with an impossibly large value for nr_events. Can you post the > actual diff for your fs/aio.c relative to linus' tree? > fio does exactly this! it passes INT_MAX. Cheers, Jeff From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Moyer Subject: Re: scsi-mq V2 Date: Thu, 10 Jul 2014 11:11:10 -0400 Message-ID: References: <1403715121-1201-1-git-send-email-hch@lst.de> <20140708144829.GA5539@infradead.org> <53BD7041.5010300@interlog.com> <53BD9A24.7010203@kernel.dk> <94D0CD8314A33A4D9D801C0FE68B402958B9628B@G9W0745.americas.hpqcorp.net> <20140710062040.GB20146@infradead.org> <20140710133609.GO12478@kvack.org> <20140710135051.GA28227@infradead.org> <53BE9AB1.6090603@kernel.dk> <94D0CD8314A33A4D9D801C0FE68B402958B96CF0@G9W0745.americas.hpqcorp.net> <20140710144539.GU12478@kvack.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20140710144539.GU12478@kvack.org> (Benjamin LaHaise's message of "Thu, 10 Jul 2014 10:45:39 -0400") Sender: linux-kernel-owner@vger.kernel.org To: Benjamin LaHaise Cc: "Elliott, Robert (Server Storage)" , Jens Axboe , Christoph Hellwig , "dgilbert@interlog.com" , James Bottomley , Bart Van Assche , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-scsi@vger.kernel.org Benjamin LaHaise writes: >> >> [ 186.339064] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >> [ 186.339065] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >> [ 186.339067] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >> [ 186.339068] ioctx_alloc: nr_events=-2 aio_max_nr=65536 >> [ 186.339069] ioctx_alloc: nr_events=-2 aio_max_nr=65536 > > Something is horribly wrong here. There is no way that value for nr_events > should be passed in to ioctx_alloc(). This implies that userland is calling > io_setup() with an impossibly large value for nr_events. Can you post the > actual diff for your fs/aio.c relative to linus' tree? > fio does exactly this! it passes INT_MAX. Cheers, Jeff