From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:58662 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbdGQPjO (ORCPT ); Mon, 17 Jul 2017 11:39:14 -0400 From: Jeff Moyer To: Lukas Czerner , Jan Kara Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH v2] fs: Fix page cache inconsistency when mixing buffered and AIO DIO References: <1499959036-9275-1-git-send-email-lczerner@redhat.com> <1500046823-25256-1-git-send-email-lczerner@redhat.com> <20170717151228.GG18199@quack2.suse.cz> <20170717152812.46yqfot6jkoqqgax@localhost.localdomain> Date: Mon, 17 Jul 2017 11:39:09 -0400 In-Reply-To: <20170717152812.46yqfot6jkoqqgax@localhost.localdomain> (Lukas Czerner's message of "Mon, 17 Jul 2017 17:28:12 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Lukas Czerner writes: > About the error case, is it not possible that some data has already been > writtent to the disk despite the error ? Yes, it's possible. However, that data is in an inconsistent state, so it shouldn't be read, anyway. Now, in the non-async path, we do the invalidation unconditionally, so I could go either way on this. I don't think it's going to matter for performance or data integrity. Cheers, Jeff