From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933311AbbKMU7z (ORCPT ); Fri, 13 Nov 2015 15:59:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44337 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932455AbbKMU7y (ORCPT ); Fri, 13 Nov 2015 15:59:54 -0500 From: Jeff Moyer To: Hannes Reinecke Cc: Jens Axboe , Alexander Graf , Christoph Hellwig , Ming Lei , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] loop: Remove unused 'bdev' argument from loop_set_capacity References: <1447143190-44589-1-git-send-email-hare@suse.de> <1447143190-44589-3-git-send-email-hare@suse.de> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 13 Nov 2015 15:59:52 -0500 In-Reply-To: <1447143190-44589-3-git-send-email-hare@suse.de> (Hannes Reinecke's message of "Tue, 10 Nov 2015 09:13:08 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hannes Reinecke writes: > Signed-off-by: Hannes Reinecke > Reviewed-by: Christoph Hellwig Introduced by the code refactoring in 7b0576a3d835b4d46ed85d817ce016e90bf293a3. Reviewed-by: Jeff Moyer > --- > drivers/block/loop.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index e790487..7272055 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -1310,7 +1310,7 @@ loop_get_status64(struct loop_device *lo, struct loop_info64 __user *arg) { > return err; > } > > -static int loop_set_capacity(struct loop_device *lo, struct block_device *bdev) > +static int loop_set_capacity(struct loop_device *lo) > { > if (unlikely(lo->lo_state != Lo_bound)) > return -ENXIO; > @@ -1373,7 +1373,7 @@ static int lo_ioctl(struct block_device *bdev, fmode_t mode, > case LOOP_SET_CAPACITY: > err = -EPERM; > if ((mode & FMODE_WRITE) || capable(CAP_SYS_ADMIN)) > - err = loop_set_capacity(lo, bdev); > + err = loop_set_capacity(lo); > break; > case LOOP_SET_DIRECT_IO: > err = -EPERM;