From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Moyer Subject: Re: [PATCH 2/3] block: Add badblock management for gendisks Date: Wed, 25 Nov 2015 13:07:41 -0500 Message-ID: References: <1448066960-20119-1-git-send-email-vishal.l.verma@intel.com> <1448066960-20119-3-git-send-email-vishal.l.verma@intel.com> <1448391837.27481.16.camel@intel.com> <1448395840.14996.8.camel@intel.com> <1448474142.5911.4.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1448474142.5911.4.camel@intel.com> (Vishal L. Verma's message of "Wed, 25 Nov 2015 17:55:42 +0000") Sender: linux-scsi-owner@vger.kernel.org To: "Verma, Vishal L" Cc: "linux-raid@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-block@vger.kernel.org" , "neilb@suse.com" , "axboe@fb.com" , "linux-nvdimm@ml01.01.org" List-Id: linux-raid.ids "Verma, Vishal L" writes: > On Wed, 2015-11-25 at 10:37 -0500, Jeff Moyer wrote: >> "Verma, Vishal L" writes: >>=20 >> > On Tue, 2015-11-24 at 14:14 -0500, Jeff Moyer wrote: >> > >=20 >> > > I'm not sure whether it makes sense to continue without badblock >> > > management for the RAID code.=C2=A0=C2=A0I was hoping Neil would= comment on >> > > that. >> > >=20 >> > > -Jeff >> >=20 >> > Not sure I follow? I believe I've kept all the badblocks >> > functionality >> > RAID already had.. >>=20 >> What I mean to say is that the RAID code had previously embedded the >> badblocks structure in one of its other data structures.=C2=A0=C2=A0= As a result, >> you would never get an allocation failure for it. >>=20 > Ah I see - I don't think that has effectively changed. 'rdev' still > contains a statically allocated badblocks structure (as opposed to > gendisk, which just stores a pointer). md used to dynamically allocat= e > the storage space inside badblocks (bb->page), and that is still the > case using badblocks_init. Ah, ok. Sorry I didn't dig into that further. Thanks, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html