Re: [PATCH] usb/gadget: initialize gadget functions helper befor functions & gadgets

From: Michal Nazarewicz <mina86@mina86.com>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
	linux-usb@vger.kernel.org
Cc: Felipe Balbi <balbi@ti.com>,
	linux-kernel@vger.kernel.org,
	Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
	Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH] usb/gadget: initialize gadget functions helper befor functions & gadgets
Date: Mon, 04 Mar 2013 23:40:25 +0100	[thread overview]
Message-ID: <xa1t621623hi.fsf@mina86.com> (raw)
In-Reply-To: <1362432489-6325-1-git-send-email-sebastian@breakpoint.cc>

[-- Attachment #1: Type: text/plain, Size: 2183 bytes --]

On Mon, Mar 04 2013, Sebastian Andrzej Siewior wrote:
> Fengguang Wu run into a kernel ops after he complied dummy_hcd and g_cdc
> into the kernel. The problem was that u_serial was used by g_cdc before
> u_serial was initialized. In the module case eveything is initialized in
> the correct order but if we compile it into the kernel we rely on
> Makefile order which I did wrong and now I correct this.
>
> Cc: Fengguang Wu <fengguang.wu@intel.com>

Should that be Reported-by?

> Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>

Acked-by: Michal Nazarewicz <mina86@mina86.com>

> ---
> I kinda assumed that this was already fixed (i.e. a patch like this was sent)
> but it seems not to be that case.
>
>  drivers/usb/gadget/Makefile |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
> index 97a13c3..1ded3d4 100644
> --- a/drivers/usb/gadget/Makefile
> +++ b/drivers/usb/gadget/Makefile
> @@ -35,6 +35,12 @@ mv_udc-y			:= mv_udc_core.o
>  obj-$(CONFIG_USB_FUSB300)	+= fusb300_udc.o
>  obj-$(CONFIG_USB_MV_U3D)	+= mv_u3d_core.o
>  
> +# USB Functions

Should there be a comment explaining why USB functions must be placed
before gadgets?

> +obj-$(CONFIG_USB_U_SERIAL)	+= u_serial.o
> +obj-$(CONFIG_USB_F_ACM)		+= f_acm.o
> +f_ss_lb-y			:= f_loopback.o f_sourcesink.o
> +obj-$(CONFIG_USB_F_SS_LB)	+= f_ss_lb.o
> +
>  #
>  # USB gadget drivers
>  #
> @@ -74,9 +80,3 @@ obj-$(CONFIG_USB_G_WEBCAM)	+= g_webcam.o
>  obj-$(CONFIG_USB_G_NCM)		+= g_ncm.o
>  obj-$(CONFIG_USB_G_ACM_MS)	+= g_acm_ms.o
>  obj-$(CONFIG_USB_GADGET_TARGET)	+= tcm_usb_gadget.o
> -
> -# USB Functions
> -obj-$(CONFIG_USB_F_ACM)		+= f_acm.o
> -f_ss_lb-y			:= f_loopback.o f_sourcesink.o
> -obj-$(CONFIG_USB_F_SS_LB)	+= f_ss_lb.o
> -obj-$(CONFIG_USB_U_SERIAL)	+= u_serial.o

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--

[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]

[-- Attachment #2.2: Type: application/pgp-signature, Size: 835 bytes --]