All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Nazarewicz <mina86-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>
To: Krzysztof Opasiak <k.opasiak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
	jackp-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	pheatwol-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	benoit-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org,
	Andrzej Pietrasiewicz
	<andrzej.p-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	'Manu Gautam' <mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Karol Lewandowski
	<k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Marek Szyprowski
	<m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCHv2] usb: gadget: f_fs: Add flags to descriptors block
Date: Wed, 04 Jun 2014 21:06:20 +0200	[thread overview]
Message-ID: <xa1tk38wlck3.fsf@mina86.com> (raw)
In-Reply-To: <005901cf8000$c16ec090$444c41b0$%opasiak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

>> -struct usb_functionfs_descs_head {
>> -	__le32 magic;
>> -	__le32 length;
>> -	__le32 fs_count;
>> -	__le32 hs_count;
>> -} __attribute__((packed));

On Wed, Jun 04 2014, Krzysztof Opasiak <k.opasiak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> I have tried to compile FFS examples with v3.15-rc8 but I have faced an
> issue that they are unable to build due to missing definition of this
> structure.

https://lkml.org/lkml/2014/5/21/522

> The same is with adb, sdb and all userspace apps which use legacy
> API. What is the reason of removing it? Was your intentions?

It was a mistake on my part.

> Maybe would be a good idea to leave this structure untouched as legacy
> userspace API?

I don't care either way to be honest.  I guess if there's non-negligible
number of usb_functionfs_descs_head structure users out there, I can
prepare a CL adding the structure back.

> There is also no structure definition for new API, maybe suitable
> structure should be defined (struct usb_functionfs_descs_head2 for
> example) to make userspace life easier?

That structure would not have many fields though, since what exactly the
header contains depends on the flags.  Whether fs_count, hs_count and
ss_count fields are present depends on which bits in the flags are set.
So the usb_functionfs_descs_head2 structure could only contain:

	struct usb_functionfs_descs_head2 {
		__le32 magic;
		__le32 length;
		__le32 flags;
	};

I'm not sure if that would be particularly helpful.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>--<xmpp:mina86-/eSpBmjxGS4dnm+yROfE0A@public.gmane.org>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-06-04 19:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-24  9:30 [PATCH v5 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode Manu Gautam
     [not found] ` <1387877408-17567-1-git-send-email-mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-02-25  4:47   ` Manu Gautam
2014-02-25 14:01 ` [RFC] usb: gadget: f_fs: Add flags to descriptors block Michal Nazarewicz
     [not found]   ` <xa1tsir7b5uz.fsf-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>
2014-02-25 17:02     ` [PATCHv2] " Michal Nazarewicz
2014-02-25 18:32       ` Felipe Balbi
2014-02-28 10:11       ` Manu Gautam
     [not found]       ` <xa1tob1vazxh.fsf-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>
2014-06-04 14:24         ` Krzysztof Opasiak
     [not found]           ` <005901cf8000$c16ec090$444c41b0$%opasiak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-04 19:06             ` Michal Nazarewicz [this message]
2014-06-05 11:32               ` Krzysztof Opasiak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xa1tk38wlck3.fsf@mina86.com \
    --to=mina86-deaty8a+uhjqt0dzr+alfa@public.gmane.org \
    --cc=andrzej.p-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=benoit-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=jackp-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=k.lewandowsk-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=k.opasiak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=pheatwol-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.