From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Nazarewicz Subject: Re: [PATCHv2] usb: gadget: f_fs: Add flags to descriptors block Date: Wed, 04 Jun 2014 21:06:20 +0200 Message-ID: References: <1387877408-17567-1-git-send-email-mgautam@codeaurora.org> <005901cf8000$c16ec090$444c41b0$%opasiak@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <005901cf8000$c16ec090$444c41b0$%opasiak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Opasiak Cc: balbi-l0cyMroinI0@public.gmane.org, jackp-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, pheatwol-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, benoit-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org, Andrzej Pietrasiewicz , gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, 'Manu Gautam' , Karol Lewandowski , Marek Szyprowski List-Id: linux-arm-msm@vger.kernel.org >> -struct usb_functionfs_descs_head { >> - __le32 magic; >> - __le32 length; >> - __le32 fs_count; >> - __le32 hs_count; >> -} __attribute__((packed)); On Wed, Jun 04 2014, Krzysztof Opasiak wrote: > I have tried to compile FFS examples with v3.15-rc8 but I have faced = an > issue that they are unable to build due to missing definition of this > structure. https://lkml.org/lkml/2014/5/21/522 > The same is with adb, sdb and all userspace apps which use legacy > API. What is the reason of removing it? Was your intentions? It was a mistake on my part. > Maybe would be a good idea to leave this structure untouched as legac= y > userspace API? I don't care either way to be honest. I guess if there's non-negligibl= e number of usb_functionfs_descs_head structure users out there, I can prepare a CL adding the structure back. > There is also no structure definition for new API, maybe suitable > structure should be defined (struct usb_functionfs_descs_head2 for > example) to make userspace life easier? That structure would not have many fields though, since what exactly th= e header contains depends on the flags. Whether fs_count, hs_count and ss_count fields are present depends on which bits in the flags are set. So the usb_functionfs_descs_head2 structure could only contain: struct usb_functionfs_descs_head2 { __le32 magic; __le32 length; __le32 flags; }; I'm not sure if that would be particularly helpful. --=20 Best regards, _ _ =2Eo. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o =2E.o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarew= icz (o o) ooo +------ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html