All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: Heiko Voigt <hvoigt@hvoigt.net>,
	"git\@vger.kernel.org" <git@vger.kernel.org>,
	Jens Lehmann <Jens.Lehmann@web.de>,
	Fredrik Gustafsson <iveqy@iveqy.com>
Subject: Re: [PATCH] push: change submodule default to check
Date: Wed, 24 Aug 2016 11:08:57 -0700	[thread overview]
Message-ID: <xmqq1t1eqbt2.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kYxu_x2qA9fq4qAWt7GgCY3Nz51TMGQS7EbGnbm9c+kqQ@mail.gmail.com> (Stefan Beller's message of "Wed, 24 Aug 2016 09:46:42 -0700")

Stefan Beller <sbeller@google.com> writes:

> I guess we can postpone it until 3.0, though I currently think it is not a big
> issue as it helps avoiding "bugs in your workflow".
>
> On the other hand if you really want to push out the superproject without
> the submodules, you need to adapt your behavior (i.e. set an option or
> give a command line flag), and such breaking things we should delay
> until 3.0.
>
> I think I'll resend it with a proper commit message, such that we can just pick
> it up when 3.0 comes around.

A change that needs to wait until a major version bump implies that
it is possibly compatibility breaking.  So "resend IT", implying one
single step, sounds like a bad sign that the users won't have any
transition period.  Shouldn't we do the usual two-step deprecation
process, i.e. warn when an unconfigured user pushes a superproject
that may be ahead of a submodule about upcoming planned default
change with the first patch, and then flip the default in the second
patch while dropping the warning?

  reply	other threads:[~2016-08-24 18:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17 20:48 [PATCH] push: change submodule default to check Stefan Beller
2016-08-17 21:05 ` Junio C Hamano
2016-08-17 21:14   ` Stefan Beller
     [not found]     ` <20160818140922.GA5925@sandbox>
2016-08-24 16:46       ` Stefan Beller
2016-08-24 18:08         ` Junio C Hamano [this message]
2016-10-04 16:21 Slow pushes on 'pu' - even when up-to-date Jeff King
2016-10-04 16:40 ` [PATCH] push: change submodule default to check Stefan Beller
2016-10-04 17:34   ` Jeff King
2016-10-04 17:48     ` Stefan Beller
2016-10-04 17:54       ` Jeff King
2016-10-04 18:04         ` Junio C Hamano
2016-10-04 18:08           ` Stefan Beller
2016-10-04 18:28             ` Jeff King
2016-10-04 18:00   ` Junio C Hamano
2016-10-04 18:02     ` Junio C Hamano
2016-10-04 18:05     ` Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1t1eqbt2.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=hvoigt@hvoigt.net \
    --cc=iveqy@iveqy.com \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.