All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Niek van der Kooy <niekvanderkooy@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: Issue when changing staged files in a pre-commit hook
Date: Tue, 19 Jan 2016 10:44:09 -0800	[thread overview]
Message-ID: <xmqq1t9dbe9y.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACsJy8DhiYiie7+Cw3PkPJpSX7CGp-r2Mu98mLp4OMhhGdsXgQ@mail.gmail.com> (Duy Nguyen's message of "Tue, 19 Jan 2016 19:20:36 +0700")

Duy Nguyen <pclouds@gmail.com> writes:

> I think it's the intended behavior.

Yeah, pre-commit was designed for inspecting and rejecting, not for
tweaking and munging.  Perhaps "git commit" can be tightened to make
sure that pre-commit that returns successfully did not muck with the
working tree and the index?

  reply	other threads:[~2016-01-19 18:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-28 12:17 Issue when changing staged files in a pre-commit hook Niek van der Kooy
2016-01-19 11:53 ` Niek van der Kooy
2016-01-19 12:20 ` Duy Nguyen
2016-01-19 18:44   ` Junio C Hamano [this message]
2016-01-19 23:26     ` Duy Nguyen
2016-01-19 23:41       ` Junio C Hamano
2016-01-20  0:23         ` Duy Nguyen
2016-01-20  1:44           ` Junio C Hamano
2016-01-22  8:58             ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1t9dbe9y.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=niekvanderkooy@gmail.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.