All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Des Preston via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
	Des Preston <despreston@gmail.com>
Subject: Re: [PATCH v2 2/2] worktree: accept multiple paths
Date: Mon, 28 Mar 2022 18:00:00 -0700	[thread overview]
Message-ID: <xmqq35j1zi7j.fsf@gitster.g> (raw)
In-Reply-To: <1df005a4ef1e387c7f7f5486a7a8800b9cd204a8.1648500426.git.gitgitgadget@gmail.com> (Des Preston via GitGitGadget's message of "Mon, 28 Mar 2022 20:47:06 +0000")

"Des Preston via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Des Preston <despreston@gmail.com>
>
> Update the worktree usage to show that the repair command can take
> multiple paths.
>
> Signed-off-by: Des Preston <despreston@gmail.com>
> ---
>  builtin/worktree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/worktree.c b/builtin/worktree.c
> index 8682ff4c417..498975c1fd9 100644
> --- a/builtin/worktree.c
> +++ b/builtin/worktree.c
> @@ -22,7 +22,7 @@ static const char * const worktree_usage[] = {
>  	N_("git worktree move <worktree> <new-path>"),
>  	N_("git worktree prune [<options>]"),
>  	N_("git worktree remove [<options>] <worktree>"),
> -	N_("git worktree repair [<path>]"),
> +	N_("git worktree repair [<path>...]"),

The fact that this line was introduced in [PATCH 1/2] and then
needed to immediately be corrected with this patch means the
previous patch was suboptimal and this patch is "oops, the last one
was bad and here is a band-aid fix-up".

Let's not do so.  Instead, you are encouraged to pretend to be a
more perfect developer who does not make unnecessary mistake ;-)


  reply	other threads:[~2022-03-29  1:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25 18:05 [PATCH] worktree: include repair cmd in usage Des Preston via GitGitGadget
2022-03-25 19:55 ` Eric Sunshine
2022-03-28 20:47 ` [PATCH v2 0/2] " Des Preston via GitGitGadget
2022-03-28 20:47   ` [PATCH v2 1/2] " Des Preston via GitGitGadget
2022-03-28 20:47   ` [PATCH v2 2/2] worktree: accept multiple paths Des Preston via GitGitGadget
2022-03-29  1:00     ` Junio C Hamano [this message]
2022-03-29  3:00       ` Desmond Preston
2022-03-29 16:01         ` Junio C Hamano
2022-03-29 18:36           ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq35j1zi7j.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=despreston@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.