From: Junio C Hamano <gitster@pobox.com>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: Heba Waly via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Heba Waly <heba.waly@gmail.com>
Subject: Re: [PATCH 1/1] add: use advise function to display hints
Date: Mon, 06 Jan 2020 15:13:16 -0800 [thread overview]
Message-ID: <xmqq36cs89gz.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200106230712.GA181522@google.com> (Emily Shaffer's message of "Mon, 6 Jan 2020 15:07:12 -0800")
Emily Shaffer <emilyshaffer@google.com> writes:
> On Thu, Jan 02, 2020 at 03:04:01AM +0000, Heba Waly via GitGitGadget wrote:
>> From: Heba Waly <heba.waly@gmail.com>
>>
>> @@ -390,7 +390,7 @@ static int add_files(struct dir_struct *dir, int flags)
>> fprintf(stderr, _(ignore_error));
>> for (i = 0; i < dir->ignored_nr; i++)
>> fprintf(stderr, "%s\n", dir->ignored[i]->name);
>> - fprintf(stderr, _("Use -f if you really want to add them.\n"));
>> + advise(_("Use -f if you really want to add them.\n"));
>
> In the vein of the rest of your project, for me I'd rather see a
> copy-pasteable response here:
>
> "Use 'git add -f " + name + "' if you really want to add them."
>
> That is, if you know the name of the file that was being added here, you
> could provide it so the user can simply copy and go, rather than
> retyping.
Just being a devil's advocate, but you are opening a can of worms by
suggesting so---the path needs to be quoted proporly (and the way to
do so may be different depending on the shell in use), for example.
next prev parent reply other threads:[~2020-01-06 23:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 3:04 [PATCH 0/1] [Outreachy] [RFC] add: use advise function to display hints Heba Waly via GitGitGadget
2020-01-02 3:04 ` [PATCH 1/1] " Heba Waly via GitGitGadget
2020-01-02 19:54 ` Junio C Hamano
2020-01-02 22:47 ` Junio C Hamano
2020-01-07 10:54 ` Heba Waly
2020-01-07 16:35 ` Junio C Hamano
2020-01-07 23:32 ` Heba Waly
2020-01-06 23:13 ` Emily Shaffer
2020-01-06 23:18 ` Junio C Hamano
2020-01-07 4:19 ` Heba Waly
2020-01-06 23:07 ` Emily Shaffer
2020-01-06 23:13 ` Junio C Hamano [this message]
2020-01-07 23:12 ` [PATCH v2 0/1] [Outreachy] " Heba Waly via GitGitGadget
2020-01-07 23:12 ` [PATCH v2 1/1] " Heba Waly via GitGitGadget
2020-01-27 23:52 ` Emily Shaffer
2020-01-29 1:09 ` Heba Waly
2020-01-28 0:00 ` Jonathan Tan
2020-01-29 2:04 ` Heba Waly
2020-01-30 1:11 ` [PATCH v3] add: use advice API " Heba Waly via GitGitGadget
2020-01-30 21:59 ` Junio C Hamano
2020-01-31 11:16 ` Heba Waly
2020-02-05 21:18 ` Junio C Hamano
2020-02-05 22:05 ` Heba Waly
2020-02-05 22:18 ` Junio C Hamano
2020-02-05 23:05 ` Heba Waly
2020-02-05 23:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq36cs89gz.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=heba.waly@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.