From: Junio C Hamano <gitster@pobox.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git mailing list" <git@vger.kernel.org>
Subject: Re: [PATCH v2 6/8] travis-ci: don't install 'language-pack-is' package
Date: Mon, 18 Dec 2017 14:34:27 -0800 [thread overview]
Message-ID: <xmqq3747y8b0.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <AB053B56-5318-47D4-8ADE-0A72B9860BED@gmail.com> (Lars Schneider's message of "Mon, 18 Dec 2017 23:17:39 +0100")
Lars Schneider <larsxschneider@gmail.com> writes:
>> It seems we would loose coverage with this patch, so it should be
>> dropped.
>
> Yeah. I think we should add a comment to the travis.yml to avoid
> future confusion. I'll do it unless you beat me to it with a re-roll.
Rather, it should be commented close to where is locale is used in
tests, and possibly in t/README, I would think. Those who want to
use t/*, not necessarily using Travis, would benefit from the hint,
"installing icelandic locale may give you better test coverage", or
something like that.
next prev parent reply other threads:[~2017-12-18 22:34 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 11:55 [PATCH] travis-ci: fix running P4 and Git LFS tests in Linux build jobs SZEDER Gábor
2017-12-11 23:34 ` [PATCH 0/4] travis-ci: clean up setting environment variables SZEDER Gábor
2017-12-11 23:34 ` [PATCH 1/4] travis-ci: use 'set -x' in 'ci/*' scripts for extra tracing output SZEDER Gábor
2017-12-12 18:00 ` Lars Schneider
2017-12-12 18:43 ` SZEDER Gábor
2017-12-13 23:10 ` Lars Schneider
2017-12-14 23:51 ` SZEDER Gábor
2017-12-15 12:10 ` Johannes Schindelin
2017-12-15 13:06 ` SZEDER Gábor
2017-12-15 15:32 ` Johannes Schindelin
2017-12-11 23:34 ` [PATCH 2/4] travis-ci: introduce a $jobname variable for 'ci/*' scripts SZEDER Gábor
2017-12-11 23:34 ` [PATCH 3/4] travis-ci: move setting environment variables to 'ci/lib-travisci.sh' SZEDER Gábor
2017-12-11 23:34 ` [PATCH 4/4] travis-ci: set GIT_TEST_HTTPD in 'ci/lib-travisci.sh' SZEDER Gábor
2017-12-16 12:54 ` [PATCH v2 0/8] Travis CI cleanups SZEDER Gábor
2017-12-16 12:54 ` [PATCH v2 1/8] travis-ci: use 'set -x' in select 'ci/*' scripts for extra tracing SZEDER Gábor
2017-12-16 12:55 ` [PATCH v2 2/8] travis-ci: introduce a $jobname variable for 'ci/*' scripts SZEDER Gábor
2017-12-16 12:57 ` [PATCH v2 3/8] travis-ci: move setting environment variables to 'ci/lib-travisci.sh' SZEDER Gábor
2017-12-16 12:57 ` [PATCH v2 4/8] travis-ci: set GIT_TEST_HTTPD in 'ci/lib-travisci.sh' SZEDER Gábor
2017-12-16 12:57 ` [PATCH v2 5/8] travis-ci: don't install default addon packages for the 32 bit Linux build SZEDER Gábor
2017-12-16 12:57 ` [PATCH v2 6/8] travis-ci: don't install 'language-pack-is' package SZEDER Gábor
2017-12-18 21:33 ` Lars Schneider
2017-12-18 22:04 ` SZEDER Gábor
2017-12-18 22:17 ` Lars Schneider
2017-12-18 22:34 ` Junio C Hamano [this message]
2017-12-19 12:22 ` SZEDER Gábor
2017-12-16 12:58 ` [PATCH v2 7/8] travis-ci: save prove state for the 32 bit Linux build SZEDER Gábor
2017-12-16 12:58 ` [PATCH v2 8/8] travis-ci: only print test failures if there are test results available SZEDER Gábor
2017-12-16 18:32 ` Eric Sunshine
2017-12-16 22:48 ` [PATCH v2 8/8] travis-ci: only print test failures if there are SZEDER Gábor
2017-12-17 0:02 ` Eric Sunshine
2017-12-16 16:43 ` [PATCH v2 1/8] travis-ci: use 'set -x' in select 'ci/*' scripts for extra tracing Johannes Schindelin
2017-12-18 21:53 ` Lars Schneider
2017-12-18 21:46 ` [PATCH v2 0/8] Travis CI cleanups Lars Schneider
2017-12-27 16:35 ` [PATCH v3 0/4] Rest of the Travis CI fixes SZEDER Gábor
2017-12-27 16:36 ` [PATCH v3 1/4] travis-ci: fine tune the use of 'set -x' in 'ci/*' scripts SZEDER Gábor
2017-12-27 18:35 ` Lars Schneider
2017-12-27 16:36 ` [PATCH v3 2/4] travis-ci: don't install default addon packages for the 32 bit Linux build SZEDER Gábor
2017-12-27 18:41 ` Lars Schneider
2017-12-27 16:36 ` [PATCH v3 3/4] travis-ci: save prove state " SZEDER Gábor
2017-12-27 18:46 ` Lars Schneider
2017-12-27 21:42 ` SZEDER Gábor
2017-12-28 11:17 ` Lars Schneider
2017-12-27 16:36 ` [PATCH v3 4/4] travis-ci: only print test failures if there are test results available SZEDER Gábor
2017-12-27 18:52 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq3747y8b0.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.