All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
	Eric Wong <e@80x24.org>, "Kyle J. McKay" <mackyle@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/2] pager: move pager-specific setup into the build
Date: Mon, 01 Aug 2016 11:07:37 -0700	[thread overview]
Message-ID: <xmqq37mol5w6.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160801172459.wz7wigmytxpfvs22@sigill.intra.peff.net> (Jeff King's message of "Mon, 1 Aug 2016 13:24:59 -0400")

Jeff King <peff@peff.net> writes:

> I'm not too worried about spaces here. This is a resurrection of an old
> discussion, and in all that time, I think the only realistic suggestions
> for built-in values have been pretty tame.
>
> If this were used to parse arbitrary user-provided runtime values, I'd
> be more concerned. But I'm not sure why we would need that. Your $EDITOR
> example is arbitrary shell code, and we let the shell handle it (modulo
> some efficiency shortcuts). Likewise, fancy runtime things should go in
> GIT_PAGER, where you can not only set options with spaces, but do fancy
> things like pipes, shell functions, etc.
>
> The use of stringify() here is funny to me; I think there is a cpp
> tokenizing step in the middle that will do things like gobble up
> whitespace (but I'm not sure if it has other possible effects). I think
> our more usual method here would be to C-quote in the Makefile (with the
> equivalent of 's/\\/\\\\/g; s/"/\\"/g'), and then pass it to the
> compiler as a string literal, like -DPAGER_ENV=\"$(PAGER_ENV_CQ_SQ\".

All sensible arguments, including the rationale to reject 2/2.

Thanks.

  reply	other threads:[~2016-08-01 18:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01  1:05 [PATCH 0/2] add PAGER_ENV to build and core.pagerEnv to config Eric Wong
2016-08-01  1:05 ` [PATCH 1/2] pager: move pager-specific setup into the build Eric Wong
2016-08-01  1:43   ` brian m. carlson
2016-08-01  7:00     ` Eric Wong
2016-08-01  8:57       ` Jakub Narębski
2016-08-01 10:40         ` brian m. carlson
2016-08-01 17:24     ` Jeff King
2016-08-01 18:07       ` Junio C Hamano [this message]
2016-08-01 17:46   ` Duy Nguyen
2016-08-01 17:52     ` Jeff King
2016-08-01 18:01       ` Duy Nguyen
2016-08-01 18:07         ` Jeff King
2016-08-01  1:05 ` [PATCH 2/2] pager: implement core.pagerEnv in config Eric Wong
2016-08-01 17:28   ` Jeff King
2016-08-01 21:49 ` [PATCH 0/1 v2] add PAGER_ENV to build Eric Wong
2016-08-01 21:49   ` [PATCH 1/1 v2] pager: move pager-specific setup into the build Eric Wong
2016-08-01 23:03     ` Junio C Hamano
2016-08-01 23:46       ` Jeff King
2016-08-02 21:14         ` Junio C Hamano
2016-08-01 23:56       ` Eric Wong
2016-08-02 21:15         ` Junio C Hamano
2016-08-03 16:19     ` Jeff King
2016-08-03 20:57       ` Junio C Hamano
2016-08-03 21:08         ` Eric Wong
2016-08-03 21:15           ` Junio C Hamano
2016-08-04  3:43             ` [PATCH v3] " Eric Wong
2016-08-04  5:34               ` Jeff King
2016-08-04 11:34                 ` Eric Wong
2016-08-04 17:53                   ` Jeff King
2016-08-04 11:40               ` [PATCH v4] " Eric Wong
2016-08-03 21:09         ` [PATCH 1/1 v2] " Jeff King
2016-08-01 21:59   ` [PATCH 0/1 v2] add PAGER_ENV to build Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq37mol5w6.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=mackyle@gmail.com \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.