All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] ref-filter: fix indentation
Date: Wed, 29 Jul 2015 10:49:17 -0700	[thread overview]
Message-ID: <xmqq3806am76.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1438185150-31730-1-git-send-email-Matthieu.Moy@imag.fr> (Matthieu Moy's message of "Wed, 29 Jul 2015 17:52:30 +0200")

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
> ---
> This is meant to be applied on top of kn/for-each-ref.

Hmm, as 2.5 is already out and we can rewind 'next' in the coming
couple of days, I am tempted to squash this in instead of applying
it on top.

Thanks.

>  ref-filter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ref-filter.c b/ref-filter.c
> index 43502a4..3fbbbeb 100644
> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -868,8 +868,8 @@ static int ref_filter_handler(const char *refname, const struct object_id *oid,
>  	struct ref_array_item *ref;
>  
>  	if (flag & REF_BAD_NAME) {
> -		  warning("ignoring ref with broken name %s", refname);
> -		  return 0;
> +		warning("ignoring ref with broken name %s", refname);
> +		return 0;
>  	}
>  
>  	if (*filter->name_patterns && !match_name_as_path(filter->name_patterns, refname))

  parent reply	other threads:[~2015-07-29 17:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29 15:52 [PATCH] ref-filter: fix indentation Matthieu Moy
2015-07-29 16:11 ` Karthik Nayak
2015-07-29 17:49 ` Junio C Hamano [this message]
2015-07-29 21:18   ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq3806am76.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@imag.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.