All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Victoria Dye <vdye@github.com>
Cc: git@vger.kernel.org, "Derrick Stolee" <derrickstolee@github.com>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: What's cooking in git.git (May 2022, #07; Wed, 25)
Date: Thu, 26 May 2022 10:23:59 -0700	[thread overview]
Message-ID: <xmqq4k1c1a34.fsf@gitster.g> (raw)
In-Reply-To: <df44b0cd-bba7-19f0-4e45-c0988239cc4d@github.com> (Victoria Dye's message of "Thu, 26 May 2022 09:02:27 -0700")

Victoria Dye <vdye@github.com> writes:

>> * js/ci-github-workflow-markup (2022-05-21) 12 commits
>>  - ci: call `finalize_test_case_output` a little later
>>  - ci(github): mention where the full logs can be found
>>  - ci: use `--github-workflow-markup` in the GitHub workflow
>>  - ci(github): avoid printing test case preamble twice
>>  - ci(github): skip the logs of the successful test cases
>>  - ci: optionally mark up output in the GitHub workflow
>>  - ci/run-build-and-tests: add some structure to the GitHub workflow output
>>  - ci: make it easier to find failed tests' logs in the GitHub workflow
>>  - ci/run-build-and-tests: take a more high-level view
>>  - test(junit): avoid line feeds in XML attributes
>>  - tests: refactor --write-junit-xml code
>>  - ci: fix code style
>> 
>>  Update the GitHub workflow support to make it quicker to get to the
>>  failing test.
>> 
>>  Will merge to 'next'?
>>  source: <pull.1117.v3.git.1653171536.gitgitgadget@gmail.com>
>
> The latest version of this nicely addressed the feedback I originally had,
> particularly in improving page loading time. It's still slower than before
> this series, but IMO it's manageable (especially taking into account the
> improved information accessibility). 
>
> I don't see (or have) any other unaddressed concerns, so I'm in favor of
> moving it to 'next'.

I see Ævar sent another reroll of "rebuild the base" and "then
rebase a (hopefully) equivalent of this series on top", but I think
it is unhealthy to keep doing that.  Does the latest "rebuild the
base" part look unsalvageably and fundamentally bad that it is not
worth our time to consider joining forces to polish it sufficiently
and then build this on top?

If that is the case, then I am OK to merge this to 'next' to cast it
in stone, and then the let "rebuild the base" part once die, to be
reborn as many "tweak the way things work to (clarify|optimize) X"
follow-up topics.

Thanks.

  reply	other threads:[~2022-05-26 17:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26  8:41 What's cooking in git.git (May 2022, #07; Wed, 25) Junio C Hamano
2022-05-26 16:02 ` Victoria Dye
2022-05-26 17:23   ` Junio C Hamano [this message]
2022-05-26 18:02     ` Ævar Arnfjörð Bjarmason
2022-05-26 18:30     ` Victoria Dye
2022-05-26 18:40       ` Ævar Arnfjörð Bjarmason
2022-05-26 23:10       ` Junio C Hamano
2022-05-26 18:08 ` tb/cruft-packs (was Re: What's cooking in git.git (May 2022, #07; Wed, 25)) Taylor Blau
2022-05-26 18:10 ` What's cooking in git.git (May 2022, #07; Wed, 25) Taylor Blau
2022-05-26 20:17   ` Junio C Hamano
2022-05-26 18:11 ` tb/midx-race-in-pack-objects (was Re: What's cooking in git.git (May 2022, #07; Wed, 25)) Taylor Blau
2022-05-26 18:49 ` sg/build-gitweb (was: " Ævar Arnfjörð Bjarmason
2022-05-26 19:06   ` sg/build-gitweb Junio C Hamano
2022-05-26 18:51 ` jc/http-clear-finished-pointer (was: What's cooking in git.git (May 2022, #07; Wed, 25)) Ævar Arnfjörð Bjarmason
2022-05-26 19:37   ` Re* jc/http-clear-finished-pointer Junio C Hamano
2022-05-27 20:41     ` Johannes Schindelin
2022-05-27 21:35       ` Junio C Hamano
2022-06-01  7:26     ` Ævar Arnfjörð Bjarmason
2022-06-01 15:48       ` Junio C Hamano
2022-05-26 18:54 ` js/bisect-in-c (was: What's cooking in git.git (May 2022, #07; Wed, 25)) Ævar Arnfjörð Bjarmason
2022-05-26 19:38   ` js/bisect-in-c Junio C Hamano
2022-05-26 20:00     ` js/bisect-in-c Junio C Hamano
2022-05-27 12:52       ` js/bisect-in-c Ævar Arnfjörð Bjarmason
2022-05-26 18:57 ` jx/l10n-workflow-change (was: What's cooking in git.git (May 2022, #07; Wed, 25)) Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4k1c1a34.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=vdye@github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.