From: Junio C Hamano <gitster@pobox.com>
To: steadmon@google.com
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH v3] archive: initialize archivers earlier
Date: Tue, 23 Oct 2018 13:09:43 +0900 [thread overview]
Message-ID: <xmqq4lddtibc.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <39a4e7bf8f3ebc5803393f357d1ee7dc9806252f.1540251936.git.steadmon@google.com> (steadmon's message of "Mon, 22 Oct 2018 16:54:47 -0700")
steadmon@google.com writes:
> diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh
> index 2a97b27b0a..cfd5ca492f 100755
> --- a/t/t5000-tar-tree.sh
> +++ b/t/t5000-tar-tree.sh
> @@ -39,6 +39,8 @@ test_lazy_prereq TAR_NEEDS_PAX_FALLBACK '
>
> test_lazy_prereq GZIP 'gzip --version'
>
> +test_lazy_prereq ZIP 'zip --version'
> +
There are a handful of zip implementations; Info-ZIP found on many
Linux distros does support 'zip --version', but we may want to make
sure this test covers different implementations of zip sufficiently.
Queuing this patch (or an update of it) on 'pu' and hoping those
with zip from different origins to try it would not help very much,
either, as zip implementations that do not react to "zip --version"
would silently turn the prereq off without breaking anything.
In any case, please refrain from adding any ZIP prerequiste to t5000
which is about tar; t5003-archive-zip may be a much better fit. It
has an already working machinery that validates the generated zip
archive under UNZIP prerequisite, so we may not even have to invent
our own ZIP prereq if we did so.
> @@ -206,6 +208,19 @@ test_expect_success 'git archive with --output, override inferred format' '
> test_cmp_bin b.tar d4.zip
> '
>
> +test_expect_success GZIP 'git archive with --output and --remote creates .tgz' '
> + git archive --output=d5.tgz --remote=. HEAD &&
> + gzip -d -c < d5.tgz > d5.tar &&
> + test_cmp_bin b.tar d5.tar
> +'
We try to write redirections without SP between redirection operator
and target filename, i.e. "gzip -d -c <d5.tgz >d5.tar".
Thanks.
next prev parent reply other threads:[~2018-10-23 4:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 23:19 [PATCH 0/1] Fix format detection when archiving remotely steadmon
2018-10-19 23:19 ` [PATCH 1/1] archive: init archivers before determining format steadmon
2018-10-19 23:59 ` Jeff King
2018-10-22 3:24 ` Junio C Hamano
2018-10-22 21:47 ` Josh Steadmon
2018-10-22 22:30 ` Jeff King
2018-10-19 23:41 ` [PATCH 0/1] Fix format detection when archiving remotely Jeff King
2018-10-22 21:46 ` Josh Steadmon
2018-10-22 21:48 ` [PATCH v2] archive: initialize archivers earlier steadmon
2018-10-22 22:35 ` Jeff King
2018-10-22 23:51 ` Josh Steadmon
2018-10-23 0:06 ` Jeff King
2018-10-23 0:23 ` Josh Steadmon
2018-10-22 23:54 ` [PATCH v3] " steadmon
2018-10-23 0:20 ` [PATCH v4] " steadmon
2018-10-23 4:09 ` Junio C Hamano [this message]
2018-10-25 20:29 ` [PATCH v3] " Josh Steadmon
2018-10-25 20:32 ` [PATCH v5] " steadmon
2018-10-25 21:12 ` Jeff King
2018-10-26 1:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4lddtibc.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.