From: Junio C Hamano <gitster@pobox.com>
To: larsxschneider@gmail.com
Cc: git@vger.kernel.org, peff@peff.net, ramsay@ramsayjones.plus.com,
Johannes.Schindelin@gmx.de
Subject: Re: [PATCH v6 4/4] config: add '--show-origin' option to print the origin of a config value
Date: Mon, 22 Feb 2016 09:43:25 -0800 [thread overview]
Message-ID: <xmqq4md08wua.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1455873362-66998-5-git-send-email-larsxschneider@gmail.com> (larsxschneider@gmail.com's message of "Fri, 19 Feb 2016 10:16:02 +0100")
larsxschneider@gmail.com writes:
> +test_expect_success '--show-origin with --list' '
> + cat >expect <<-EOF &&
> + file:$HOME/.gitconfig user.global=true
> + file:$HOME/.gitconfig user.override=global
> + file:$HOME/.gitconfig include.path=$INCLUDE_DIR/absolute.include
> + file:$INCLUDE_DIR/absolute.include user.absolute=include
> + file:.git/config user.local=true
> + file:.git/config user.override=local
> + file:.git/config include.path=../include/relative.include
> + file:.git/../include/relative.include user.relative=include
> + cmdline: user.cmdline=true
> + EOF
> ...
> +test_expect_success '--show-origin stdin' '
> + cat >expect <<-\EOF &&
> + stdin: user.custom=true
> + EOF
I do recall there was some bikeshedding^Wdesigning discussion, in
which I chose not to participate, on the output format, how
origin-type and origin-value are given in the output in an
unambiguous way that is easy to understand by the end users.
Does the above reflect the concensus from the discussion? Just
double checking.
next prev parent reply other threads:[~2016-02-22 17:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 9:15 [PATCH v6 0/4] config: add '--sources' option to print the source of a config value larsxschneider
2016-02-19 9:15 ` [PATCH v6 1/4] t: do not hide Git's exit code in tests using 'nul_to_q' larsxschneider
2016-02-19 9:16 ` [PATCH v6 2/4] rename git_config_from_buf to git_config_from_mem larsxschneider
2016-02-19 9:16 ` [PATCH v6 3/4] config: add 'origin_type' to config_source struct larsxschneider
2016-02-19 9:16 ` [PATCH v6 4/4] config: add '--show-origin' option to print the origin of a config value larsxschneider
2016-02-22 17:43 ` Junio C Hamano [this message]
2016-02-22 17:58 ` Jeff King
2016-02-22 18:37 ` Junio C Hamano
2016-03-02 17:33 ` Johannes Sixt
2016-03-03 7:38 ` Lars Schneider
2016-03-03 18:36 ` Johannes Sixt
2016-03-22 14:44 ` Johannes Schindelin
2016-03-21 8:53 ` Lars Schneider
2016-02-19 18:26 ` [PATCH v6 0/4] config: add '--sources' option to print the source " Junio C Hamano
2016-02-22 9:23 ` [PATCH v6 squash 0/2] " larsxschneider
2016-02-22 9:23 ` [PATCH v7 1/2] fixup: config: add 'origin_type' to config_source struct larsxschneider
2016-02-22 9:23 ` [PATCH v7 2/2] fixup: config: add '--show-origin' option to print the origin of a config value larsxschneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4md08wua.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.