From: Junio C Hamano <gitster@pobox.com>
To: "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH v2 1/1] sequencer: fix empty commit check when amending
Date: Sat, 23 Nov 2019 11:03:42 +0900 [thread overview]
Message-ID: <xmqq5zjb2vsx.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <037f2b2975e06847443aef46939e3c712053dedf.1574451783.git.gitgitgadget@gmail.com> (Phillip Wood via GitGitGadget's message of "Fri, 22 Nov 2019 19:43:03 +0000")
"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
> + if (!(flags & ALLOW_EMPTY)) {
> + struct commit *first_parent = current_head;
> +
> + if (flags & AMEND_MSG) {
> + if (current_head->parents) {
It is not apparent to me that somebody guarantees that this access
is safe; would we need to do things differently when !current_head?
> + first_parent = current_head->parents->item;
> + if (repo_parse_commit(r, first_parent)) {
> + res = error(_("could not parse HEAD commit"));
> + goto out;
> + }
> + } else {
> + first_parent = NULL;
> + }
> + }
next prev parent reply other threads:[~2019-11-23 2:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 14:06 [PATCH 0/1] sequencer: fix empty commit check when amending Phillip Wood via GitGitGadget
2019-11-21 14:06 ` [PATCH 1/1] " Phillip Wood via GitGitGadget
2019-11-22 6:40 ` Junio C Hamano
2019-11-22 11:01 ` Phillip Wood
2019-11-22 6:52 ` Junio C Hamano
2019-11-22 11:09 ` Phillip Wood
2019-11-22 19:43 ` [PATCH v2 0/1] " Phillip Wood via GitGitGadget
2019-11-22 19:43 ` [PATCH v2 1/1] " Phillip Wood via GitGitGadget
2019-11-23 2:02 ` Junio C Hamano
2019-11-23 2:03 ` Junio C Hamano [this message]
2019-11-23 9:54 ` Phillip Wood
2019-11-24 10:52 ` Phillip Wood
2019-11-25 3:00 ` Junio C Hamano
2019-11-25 14:23 ` Phillip Wood
2019-11-25 15:53 ` Johannes Schindelin
2019-11-25 16:10 ` Eric Sunshine
2019-11-25 22:52 ` Johannes Schindelin
2019-11-25 16:42 ` Phillip Wood
2019-11-26 1:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5zjb2vsx.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.