All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
	carenas@gmail.com, shoelzer@gmail.com, gitgitgadget@gmail.com,
	Git List <git@vger.kernel.org>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/1] poll: use GetTickCount64() to avoid wrap-around issues
Date: Mon, 05 Nov 2018 13:02:21 +0900	[thread overview]
Message-ID: <xmqq5zxcjho2.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPig+cRdaXdZPpmMKBwZziMZarr2+wrdpnyHPkSYAkoBDuvLnw@mail.gmail.com> (Eric Sunshine's message of "Sun, 4 Nov 2018 22:33:13 -0500")

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Sun, Nov 4, 2018 at 6:26 PM Junio C Hamano <gitster@pobox.com> wrote:
>> OK, thanks.  It seems that the relative silence after this message
>> is a sign that the resulting patch after squashing is what everybody
>> is happey with?
>>
>> -- >8 --
>> From: Steve Hoelzer <shoelzer@gmail.com>
>>
>> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
>> Acked-by: Steve Hoelzer <shoelzer@gmail.com>
>
> It's not clear from this who the author is.

Right.  The latter should be s-o-b and the order swapped, and
probably say "Steve wrote the original version, Johannes extended
it" in the text to match.

THanks.

  reply	other threads:[~2018-11-05  4:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 21:11 [PATCH 0/1] Make compat/poll safer on Windows Johannes Schindelin via GitGitGadget
2018-10-31 21:11 ` [PATCH 1/1] poll: use GetTickCount64() to avoid wrap-around issues Steve Hoelzer via GitGitGadget
2018-11-01 10:21   ` Johannes Sixt
2018-11-02 14:47     ` Steve Hoelzer
2018-11-02 16:43       ` Johannes Sixt
2018-11-02 17:18         ` Steve Hoelzer
2018-11-03  0:39         ` Junio C Hamano
2018-11-03  0:49           ` Junio C Hamano
2018-11-03  8:14         ` Carlo Arenas
2018-11-03 14:05           ` Johannes Sixt
2018-11-04 23:26             ` Junio C Hamano
2018-11-04 23:44               ` Randall S. Becker
2018-11-05  3:33               ` Eric Sunshine
2018-11-05  4:02                 ` Junio C Hamano [this message]
2018-11-05  7:01               ` Johannes Sixt
2018-11-05 20:28                 ` Johannes Sixt
2018-11-05 22:05                 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5zxcjho2.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=j6t@kdbg.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=shoelzer@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.