All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Jean-Noël Avila" <jn.avila@free.fr>
Cc: git@vger.kernel.org, Jiang Xin <worldhello.net@gmail.com>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH v3] l10n: reformat some localized strings for v2.23.0
Date: Tue, 06 Aug 2019 12:45:29 -0700	[thread overview]
Message-ID: <xmqq7e7qjcx2.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <xmqqo912ji1k.fsf@gitster-ct.c.googlers.com> (Junio C. Hamano's message of "Tue, 06 Aug 2019 10:54:47 -0700")

Junio C Hamano <gitster@pobox.com> writes:

>> +static char warn_show_forced_updates[] =
>> +N_("Fetch normally indicates which branches had a forced update,\n"
>> +   "but that check has been disabled. To re-enable, use '--show-forced-updates'\n"
>> +   "flag or run 'git config fetch.showForcedUpdates true'.");
>> ...
>> +                  warning(_(warn_show_forced_updates));

This unfortunately triggers a false positive format-security
violation.   Turning it into "static const char var[]" would
squelch it, which I did for today's integration.


      parent reply	other threads:[~2019-08-06 19:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30  3:35 [L10N] Kickoff for Git 2.23.0 round #1 Jiang Xin
2019-08-03 10:18 ` [RFC] l10n: fix some typos for v2.23.0 Jean-Noël Avila
2019-08-03 13:50   ` Jiang Xin
2019-08-03 19:59 ` [PATCH v2] l10n: reformat some localized strings " Jean-Noël Avila
2019-08-03 23:45   ` Jeff King
2019-08-04 11:01     ` Jean-Noël AVILA
2019-08-05  4:21       ` Jeff King
2019-08-05 18:49     ` Junio C Hamano
2019-08-05 21:15       ` Jeff King
2019-08-06 17:19 ` [PATCH v3] " Jean-Noël Avila
2019-08-06 17:54   ` Junio C Hamano
2019-08-06 18:10     ` Jeff King
2019-08-06 19:45     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7e7qjcx2.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jn.avila@free.fr \
    --cc=peff@peff.net \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.