From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH 6/6] pack-objects: reuse on-disk deltas for thin "have" objects
Date: Tue, 21 Aug 2018 13:52:33 -0700 [thread overview]
Message-ID: <xmqq7ekj8msu.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180821201431.GA23263@sigill.intra.peff.net> (Jeff King's message of "Tue, 21 Aug 2018 16:14:31 -0400")
Jeff King <peff@peff.net> writes:
> Another is to tighten the check. Something like this seems more
> sensible:
Great minds think alike; is it a space was exactly what I was toying
with before I went to lunch. FWIW I saw the full test suite passes
when I came back and then saw you had an identical patch ;-)
> I think there really are two bugs here, though. The find_patch_start()
> check is overly lax, but we also should not have to use it at all when
> we know there is no patch.
Yes, I was grepping for callchains, and it appeared none of them
actually expected us to feed "log plus --- plus patch" format. The
obvious candidate to take it is "am" but we ask mailinfo to do the
splitting before the log message part even hits the rest of the
system. So my inclination right now is to see if that is truly the
case and get rid of that bogus "patch start" thing, and if not, add
a flag to let the caller say "I know we only have message" to the
callchain.
next prev parent reply other threads:[~2018-08-21 20:52 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 18:41 [PATCH] test-tool.h: include git-compat-util.h Jeff King
2018-08-21 19:03 ` Junio C Hamano
2018-08-21 19:06 ` [PATCH 1/6] t/perf: factor boilerplate out of test_perf Jeff King
2018-08-21 19:06 ` [PATCH 2/6] t/perf: factor out percent calculations Jeff King
2018-08-21 19:06 ` [PATCH 3/6] t/perf: add infrastructure for measuring sizes Jeff King
2018-08-22 13:40 ` Derrick Stolee
2018-08-22 15:31 ` Jeff King
2018-08-21 19:06 ` [PATCH 4/6] t/perf: add perf tests for fetches from a bitmapped server Jeff King
2018-08-21 19:07 ` [PATCH 5/6] pack-bitmap: save "have" bitmap from walk Jeff King
2018-08-21 19:47 ` Derrick Stolee
2018-08-21 19:54 ` Jeff King
2018-08-31 15:23 ` Ævar Arnfjörð Bjarmason
2018-08-31 22:55 ` Jeff King
2018-09-01 7:41 ` [PATCH 0/4] un-breaking pack-objects with bitmaps Jeff King
2018-09-01 7:44 ` [PATCH 1/4] bitmap_has_sha1_in_uninteresting(): drop BUG check Jeff King
2018-09-01 7:48 ` [PATCH 2/4] t5310: test delta reuse with bitmaps Jeff King
2018-09-01 8:03 ` Jeff King
2018-09-01 20:29 ` Ævar Arnfjörð Bjarmason
2018-09-01 22:46 ` Ben Peart
2018-09-02 5:51 ` Jeff King
2018-09-04 19:05 ` Stefan Beller
2018-09-04 19:45 ` Junio C Hamano
2018-09-04 20:02 ` Jeff King
2018-09-01 7:49 ` [PATCH 3/4] traverse_bitmap_commit_list(): don't free result Jeff King
2018-09-01 7:50 ` [PATCH 4/4] pack-bitmap: drop "loaded" flag Jeff King
2018-09-04 19:30 ` [PATCH 0/4] un-breaking pack-objects with bitmaps Stefan Beller
2018-09-04 20:03 ` Jeff King
2018-09-08 6:43 ` Ævar Arnfjörð Bjarmason
2018-09-10 16:53 ` Junio C Hamano
2018-09-10 18:48 ` Jeff King
2018-09-10 19:23 ` Junio C Hamano
2018-08-21 19:07 ` [PATCH 6/6] pack-objects: reuse on-disk deltas for thin "have" objects Jeff King
2018-08-21 19:43 ` Junio C Hamano
2018-08-21 19:50 ` Junio C Hamano
2018-08-21 20:07 ` Jeff King
2018-08-21 20:14 ` Jeff King
2018-08-21 20:52 ` Junio C Hamano [this message]
2018-08-21 21:30 ` Jeff King
2018-08-21 20:57 ` Junio C Hamano
2018-08-21 21:32 ` Jeff King
2018-08-23 0:43 ` [PATCH 0/9] trailer-parsing false positives Jeff King
2018-08-23 0:44 ` [PATCH 1/9] trailer: use size_t for string offsets Jeff King
2018-08-23 0:45 ` [PATCH 2/9] trailer: use size_t for iterating trailer list Jeff King
2018-08-23 0:46 ` [PATCH 3/9] trailer: pass process_trailer_opts to trailer_info_get() Jeff King
2018-08-23 0:48 ` [PATCH 4/9] interpret-trailers: tighten check for "---" patch boundary Jeff King
2018-08-23 0:49 ` [PATCH 5/9] interpret-trailers: allow suppressing "---" divider Jeff King
2018-08-23 0:50 ` [PATCH 6/9] pretty, ref-filter: format %(trailers) with no_divider option Jeff King
2018-08-23 0:50 ` [PATCH 7/9] sequencer: ignore "---" divider when parsing trailers Jeff King
2018-08-23 0:50 ` [PATCH 8/9] append_signoff: use size_t for string offsets Jeff King
2018-08-23 0:51 ` [PATCH 9/9] sequencer: handle ignore_footer when parsing trailers Jeff King
2018-08-23 18:30 ` [PATCH 0/9] trailer-parsing false positives Junio C Hamano
2018-08-24 7:26 ` Jeff King
2018-08-21 20:00 ` [PATCH 6/6] pack-objects: reuse on-disk deltas for thin "have" objects Jeff King
-- strict thread matches above, loose matches on Subject: below --
2018-08-17 20:54 [PATCH 0/6] reuse on-disk deltas for fetches with bitmaps Jeff King
2018-08-17 21:06 ` [PATCH 6/6] pack-objects: reuse on-disk deltas for thin "have" objects Jeff King
2018-08-17 22:57 ` Stefan Beller
2018-08-17 23:32 ` Jeff King
2018-08-20 21:03 ` Junio C Hamano
2018-08-20 21:42 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7ekj8msu.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.