All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Karthik Nayak <karthik.188@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH v4 04/19] for-each-ref: add '--points-at' option
Date: Mon, 22 Jun 2015 12:24:57 -0700	[thread overview]
Message-ID: <xmqq7fqvh7g6.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqpp4nblc2.fsf@anie.imag.fr> (Matthieu Moy's message of "Mon, 22 Jun 2015 21:21:33 +0200")

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> On Mon, Jun 22, 2015 at 6:15 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>>  3 & 4 as a single patch may make more sense, if we were to tolerate the
>>> "let's copy & paste first and then later remove the duplicate" as a way to
>>> postpone touching "tag.c" side in order to first concentrate on for-each-ref.
>>>
>>> I have not formed a firm opinion on what the right split of the series is, but
>>> so far (assuming that the temporary duplication is the best we can do) what
>>> I am seeing in this series makes sense to me.
>>>
>>> Thanks.
>>
>> That would mean squashing 3&4, 6&7 and 10&11 also on similar lines.
>
> I have a slight preference for keeping the pairs not squashed. This way,
> we have a clear separation "write reusable library code" / "use it". But
> I'm fine with squashing if others prefer.

As I cannot firmly say that "copy & paste first and then later
clean-up" is bad and we should split them in different way, I
am fine with leaving them separate as they are.

  reply	other threads:[~2015-06-22 19:25 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-21 20:45 [PATCH v4 00/11] add options to for-each-ref Karthik Nayak
2015-06-21 20:48 ` [PATCH v4 01/19] t6301: for-each-ref tests for ref-filter APIs Karthik Nayak
2015-06-21 20:48   ` [PATCH v4 02/19] tag: libify parse_opt_points_at() Karthik Nayak
2015-06-21 20:48   ` [PATCH v4 03/19] ref-filter: implement '--points-at' option Karthik Nayak
2015-06-22 22:36     ` Eric Sunshine
2015-06-23 10:49       ` Karthik Nayak
2015-06-21 20:48   ` [PATCH v4 04/19] for-each-ref: add " Karthik Nayak
2015-06-22  0:45     ` Junio C Hamano
2015-06-22 19:03       ` Karthik Nayak
2015-06-22 19:21         ` Matthieu Moy
2015-06-22 19:24           ` Junio C Hamano [this message]
2015-06-22 19:27             ` Karthik Nayak
2015-06-22 19:51             ` Junio C Hamano
2015-06-22 22:38     ` Eric Sunshine
2015-06-23 10:52       ` Karthik Nayak
2015-06-21 20:48   ` [PATCH v4 05/19] ref-filter: add parse_opt_merge_filter() Karthik Nayak
2015-06-22  0:55     ` Junio C Hamano
2015-06-22 11:13       ` Matthieu Moy
2015-06-22 16:15         ` Junio C Hamano
2015-06-22 19:00       ` Karthik Nayak
2015-06-21 20:48   ` [PATCH v4 06/19] ref-filter: implement '--merged' and '--no-merged' options Karthik Nayak
2015-06-22  1:00     ` Junio C Hamano
2015-06-22 15:11       ` Karthik Nayak
2015-06-21 20:48   ` [PATCH v4 07/19] for-each-ref: add " Karthik Nayak
2015-06-22 22:41     ` Eric Sunshine
2015-06-23 11:05       ` Karthik Nayak
2015-06-21 20:48   ` [PATCH v4 08/19] parse-option: rename parse_opt_with_commit() Karthik Nayak
2015-06-22  1:04     ` Junio C Hamano
2015-06-22 15:38       ` Karthik Nayak
2015-06-22 16:27         ` Junio C Hamano
2015-06-22 16:37           ` Karthik Nayak
2015-06-21 20:48   ` [PATCH v4 09/19] parse-options.h: add macros for '--contains' option Karthik Nayak
2015-06-21 20:48   ` [PATCH v4 10/19] ref-filter: implement " Karthik Nayak
2015-06-21 20:48   ` [PATCH v4 11/19] for-each-ref: add " Karthik Nayak
2015-06-21 20:51 ` [PATCH v4 00/11] add options to for-each-ref Karthik Nayak
2015-06-22  0:41   ` Junio C Hamano
2015-06-22 14:48     ` Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7fqvh7g6.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.