From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 6AA52202F2 for ; Tue, 21 Nov 2017 03:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752246AbdKUDKZ (ORCPT ); Mon, 20 Nov 2017 22:10:25 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:56220 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751877AbdKUDKY (ORCPT ); Mon, 20 Nov 2017 22:10:24 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 4C720BC8EC; Mon, 20 Nov 2017 22:10:23 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=kPbujsEkalsC9rU5bdp+CZ8BP+0=; b=pmSGPc eFKfrfT01RTioEEWKBQbSb89DT9jXfz80eRkUI61ozqASVDJaKxCjP26CRFTQXvu Qbb4qtNUn79iPEEebDIUp3FeFPHIY1juGW9Isrw/FDGf4nY1ceqf6OI4xNMc43Q4 NzfEC9PHLSbc0mTjYkokng+eBulOBTwE+aCWc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=wcQmsk7tUxWHixdxf3iJ7PLvxYLfMFhw DOFzErIcpPhujh1CwI6jTh1oLdDdmyD1wnhq+zj/qGH3tYvZoBXpCL7IKX1spxH+ NtwTKZxDgrEYf5X9JBy4DlEbMOA4xZqJjoJWYyLJ+epshyDLHH3vOtFyGrBtQ5Q8 8toqfjgXeCQ= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 458CBBC8EB; Mon, 20 Nov 2017 22:10:23 -0500 (EST) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id BCA03BC8EA; Mon, 20 Nov 2017 22:10:22 -0500 (EST) From: Junio C Hamano To: Ramsay Jones Cc: vmiklos@suse.cz, GIT Mailing-list Subject: Re: [PATCH] sequencer: make sign_off_header a file local symbol References: Date: Tue, 21 Nov 2017 12:10:21 +0900 In-Reply-To: (Junio C. Hamano's message of "Tue, 21 Nov 2017 10:06:11 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 834D6F3A-CE69-11E7-9518-8EF31968708C-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > Ramsay Jones writes: > >> Signed-off-by: Ramsay Jones >> --- >> >> Hi Miklos, >> >> If you need to re-roll your 'mv/cherry-pick-s' branch, could you >> please squash this into the relevant patch (commit 5ed75e2a3f, >> "cherry-pick: don't forget -s on failure", 14-09-2017). > > What automated procedure are you using to produce these comments? > > The commit is from 14-09-2012, not from a few months ago, and is > part of Git 1.8.0 and upwards, which won't be rerolled. Please add > a check to see if the culprit is already in 'next' or something. > > Will queue as _your_ fix, not a potential squash into another > commit. > > Thanks, as always, for your attention to detail. Yuck. Somebody in flight does use this symbol from elsewhere, so it cannot be made static. Let's drop this patch for now.